current view persists during session, code cleanup

src-ui/src/app/components/document-list/document-list.component.html

@@ -1,4 +1,4 @@
-<app-page-header [title]="docs.viewConfig ? docs.viewConfig.title : 'Documents'">
+<app-page-header [title]="getTitle()">
 
   <div class="btn-group btn-group-toggle mr-2" ngbRadioGroup [(ngModel)]="displayMode"
     (ngModelChange)="saveDisplayMode()">
@@ -21,14 +21,13 @@
       </svg>
     </label>
   </div>
-  <div class="btn-group btn-group-toggle mr-2" ngbRadioGroup [(ngModel)]="docs.currentSortDirection"
-    (ngModelChange)="reload()"
-    *ngIf="!docs.viewConfig">
+  <div class="btn-group btn-group-toggle mr-2" ngbRadioGroup [(ngModel)]="docs.sortDirection"
+    *ngIf="!docs.viewId">
     <div ngbDropdown class="btn-group">
       <button class="btn btn-outline-secondary btn-sm" id="dropdownBasic1" ngbDropdownToggle>Sort by</button>
       <div ngbDropdownMenu aria-labelledby="dropdownBasic1">
         <button *ngFor="let f of getSortFields()" ngbDropdownItem (click)="setSort(f.field)"
-          [class.active]="docs.currentSortField == f.field">{{f.name}}</button>
+          [class.active]="docs.sortField == f.field">{{f.name}}</button>
       </div>
     </div>
     <label ngbButtonLabel class="btn-outline-secondary btn-sm">
@@ -44,7 +43,7 @@
       </svg>
     </label>
   </div>
-  <div class="btn-group" *ngIf="!docs.viewConfig">
+  <div class="btn-group" *ngIf="!docs.viewId">
 
     <button type="button" class="btn btn-sm btn-outline-secondary" (click)="showFilter=!showFilter">
       <svg class="toolbaricon" fill="currentColor">
@@ -62,7 +61,6 @@
       </div>
     </div>
 
-
   </div>
 </app-page-header>
 

src-ui/src/app/components/document-list/document-list.component.ts

@@ -26,13 +26,16 @@ export class DocumentListComponent implements OnInit {
   filterRules: FilterRule[] = []
   showFilter = false
 
+  getTitle() {
+    return this.docs.viewConfigOverride ? this.docs.viewConfigOverride.title : "Documents"
+  }
+
   getSortFields() {
     return DOCUMENT_SORT_FIELDS
   }
 
   setSort(field: string) {
-    this.docs.currentSortField = field
-    this.reload()
+    this.docs.sortField = field
   }
 
   saveDisplayMode() {
@@ -45,11 +48,11 @@ export class DocumentListComponent implements OnInit {
     }
     this.route.paramMap.subscribe(params => {
       if (params.has('id')) {
-        this.docs.viewConfig = this.savedViewConfigService.getConfig(params.get('id'))
+        this.docs.viewConfigOverride = this.savedViewConfigService.getConfig(params.get('id'))
       } else {
-        this.filterRules = cloneFilterRules(this.docs.currentFilterRules)
+        this.filterRules = this.docs.filterRules
         this.showFilter = this.filterRules.length > 0
-        this.docs.viewConfig = null
+        this.docs.viewConfigOverride = null
       }
       this.reload()
     })
@@ -60,28 +63,24 @@ export class DocumentListComponent implements OnInit {
   }
 
   applyFilterRules() {
-    this.docs.setFilterRules(this.filterRules)
-    this.reload()
+    this.docs.filterRules = this.filterRules
   }
 
   loadViewConfig(config: SavedViewConfig) {
     this.filterRules = cloneFilterRules(config.filterRules)
-    this.docs.setFilterRules(config.filterRules)
-    this.docs.currentSortField = config.sortField
-    this.docs.currentSortDirection = config.sortDirection
-    this.reload()
+    this.docs.loadViewConfig(config)
   }
 
   saveViewConfig() {
     let modal = this.modalService.open(SaveViewConfigDialogComponent, {backdrop: 'static'})
     modal.componentInstance.saveClicked.subscribe(formValue => {
       this.savedViewConfigService.saveConfig({
-        filterRules: cloneFilterRules(this.filterRules),
         title: formValue.title,
         showInDashboard: formValue.showInDashboard,
         showInSideBar: formValue.showInSideBar,
-        sortDirection: this.docs.currentSortDirection,
-        sortField: this.docs.currentSortField
+        filterRules: this.docs.filterRules,
+        sortDirection: this.docs.sortDirection,
+        sortField: this.docs.sortField
       })
       modal.close()
     })