From 08102c95b5957863e222c5bc2ab4673350d8f9dc Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Fri, 12 Sep 2025 21:08:16 -0700
Subject: [PATCH] Remove the None case

---
 src/documents/admin.py | 2 +-
 src/documents/tasks.py | 5 +----
 src/documents/views.py | 2 +-
 3 files changed, 3 insertions(+), 6 deletions(-)

diff --git a/src/documents/admin.py b/src/documents/admin.py
index aad649acb..c6f179e2a 100644
--- a/src/documents/admin.py
+++ b/src/documents/admin.py
@@ -44,7 +44,7 @@ class TagAdmin(GuardedModelAdmin, TreeNodeModelAdmin):
 
         # sync parent tags on documents if changed
         new_parent = obj.get_parent()
-        if old_parent != new_parent:
+        if new_parent and old_parent != new_parent:
             update_document_parent_tags(obj, new_parent)
 
 
diff --git a/src/documents/tasks.py b/src/documents/tasks.py
index 0be16274d..1f491a0e9 100644
--- a/src/documents/tasks.py
+++ b/src/documents/tasks.py
@@ -517,14 +517,11 @@ def check_scheduled_workflows():
                         )
 
 
-def update_document_parent_tags(tag: Tag, new_parent: Tag | None) -> None:
+def update_document_parent_tags(tag: Tag, new_parent: Tag) -> None:
     """
     When a tag's parent changes, ensure all documents containing the tag also have
     the parent tag (and its ancestors) applied.
     """
-    if new_parent is None:
-        return
-
     DocumentTagRelationship = Document.tags.through
 
     doc_ids: list[int] = list(
diff --git a/src/documents/views.py b/src/documents/views.py
index 21a6ba082..4bd3707ce 100644
--- a/src/documents/views.py
+++ b/src/documents/views.py
@@ -346,7 +346,7 @@ class TagViewSet(ModelViewSet, PermissionsAwareDocumentCountMixin):
         old_parent = self.get_object().get_parent()
         tag = serializer.save()
         new_parent = tag.get_parent()
-        if old_parent != new_parent:
+        if new_parent and old_parent != new_parent:
             update_document_parent_tags(tag, new_parent)