Chore: refactor loading stuff to be more DRY

This commit is contained in:
shamoon
2024-12-09 12:36:48 -08:00
parent c2e34b36ce
commit 0a7c296194
34 changed files with 87 additions and 110 deletions

View File

@@ -29,8 +29,8 @@ describe('LoadingComponentWithPermissions', () => {
expect(component.loading).toBeTruthy()
})
it('should have reveal set to false by default', () => {
expect(component.reveal).toBeFalsy()
it('should have show set to false by default', () => {
expect(component.show).toBeFalsy()
})
it('should call next and complete on unsubscribeNotifier with itself on destroy', () => {

View File

@@ -8,7 +8,7 @@ export abstract class LoadingComponentWithPermissions
implements OnDestroy
{
public loading: boolean = true
public reveal: boolean = false
public show: boolean = false
protected unsubscribeNotifier: Subject<any> = new Subject()