From 0eb765c3e8f6c77a93edd32e7a031e96ce502e6c Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Thu, 27 Feb 2025 10:19:07 -0800
Subject: [PATCH] Fix: small frontend css class fixes, remove unused component

---
 .../select-dialog.component.html              | 14 --------
 .../select-dialog.component.scss              |  0
 .../select-dialog.component.spec.ts           | 36 -------------------
 .../select-dialog/select-dialog.component.ts  | 33 -----------------
 .../common/toast/toast.component.html         |  2 +-
 .../save-view-config-dialog.component.html    |  2 +-
 src-ui/src/theme.scss                         |  4 ---
 7 files changed, 2 insertions(+), 89 deletions(-)
 delete mode 100644 src-ui/src/app/components/common/select-dialog/select-dialog.component.html
 delete mode 100644 src-ui/src/app/components/common/select-dialog/select-dialog.component.scss
 delete mode 100644 src-ui/src/app/components/common/select-dialog/select-dialog.component.spec.ts
 delete mode 100644 src-ui/src/app/components/common/select-dialog/select-dialog.component.ts

diff --git a/src-ui/src/app/components/common/select-dialog/select-dialog.component.html b/src-ui/src/app/components/common/select-dialog/select-dialog.component.html
deleted file mode 100644
index 00b2dc773..000000000
--- a/src-ui/src/app/components/common/select-dialog/select-dialog.component.html
+++ /dev/null
@@ -1,14 +0,0 @@
-<div class="modal-header">
-  <h4 class="modal-title" id="modal-basic-title">{{title}}</h4>
-  <button type="button" class="btn-close" aria-label="Close" (click)="cancelClicked()">
-  </button>
-</div>
-<div class="modal-body">
-
-  <pngx-input-select [items]="objects" [title]="message" [(ngModel)]="selected"></pngx-input-select>
-
-</div>
-<div class="modal-footer">
-  <button type="button" class="btn btn-outline-dark" (click)="cancelClicked()" i18n>Cancel</button>
-  <button type="button" class="btn btn-primary" (click)="selectClicked.emit(selected)" i18n>Select</button>
-</div>
diff --git a/src-ui/src/app/components/common/select-dialog/select-dialog.component.scss b/src-ui/src/app/components/common/select-dialog/select-dialog.component.scss
deleted file mode 100644
index e69de29bb..000000000
diff --git a/src-ui/src/app/components/common/select-dialog/select-dialog.component.spec.ts b/src-ui/src/app/components/common/select-dialog/select-dialog.component.spec.ts
deleted file mode 100644
index d67ea42ba..000000000
--- a/src-ui/src/app/components/common/select-dialog/select-dialog.component.spec.ts
+++ /dev/null
@@ -1,36 +0,0 @@
-import { ComponentFixture, TestBed } from '@angular/core/testing'
-import { FormsModule, ReactiveFormsModule } from '@angular/forms'
-import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap'
-import { NgSelectModule } from '@ng-select/ng-select'
-import { SelectComponent } from '../input/select/select.component'
-import { SelectDialogComponent } from './select-dialog.component'
-
-describe('SelectDialogComponent', () => {
-  let component: SelectDialogComponent
-  let fixture: ComponentFixture<SelectDialogComponent>
-  let modal: NgbActiveModal
-
-  beforeEach(async () => {
-    TestBed.configureTestingModule({
-      providers: [NgbActiveModal],
-      imports: [
-        NgSelectModule,
-        FormsModule,
-        ReactiveFormsModule,
-        SelectDialogComponent,
-        SelectComponent,
-      ],
-    }).compileComponents()
-
-    modal = TestBed.inject(NgbActiveModal)
-    fixture = TestBed.createComponent(SelectDialogComponent)
-    component = fixture.componentInstance
-    fixture.detectChanges()
-  })
-
-  it('should close modal on cancel', () => {
-    const closeSpy = jest.spyOn(modal, 'close')
-    component.cancelClicked()
-    expect(closeSpy).toHaveBeenCalled()
-  })
-})
diff --git a/src-ui/src/app/components/common/select-dialog/select-dialog.component.ts b/src-ui/src/app/components/common/select-dialog/select-dialog.component.ts
deleted file mode 100644
index 3c6c98577..000000000
--- a/src-ui/src/app/components/common/select-dialog/select-dialog.component.ts
+++ /dev/null
@@ -1,33 +0,0 @@
-import { Component, EventEmitter, Input, Output } from '@angular/core'
-import { FormsModule, ReactiveFormsModule } from '@angular/forms'
-import { NgbActiveModal } from '@ng-bootstrap/ng-bootstrap'
-import { ObjectWithId } from 'src/app/data/object-with-id'
-import { SelectComponent } from '../input/select/select.component'
-
-@Component({
-  selector: 'pngx-select-dialog',
-  templateUrl: './select-dialog.component.html',
-  styleUrls: ['./select-dialog.component.scss'],
-  imports: [SelectComponent, FormsModule, ReactiveFormsModule],
-})
-export class SelectDialogComponent {
-  constructor(public activeModal: NgbActiveModal) {}
-
-  @Output()
-  public selectClicked = new EventEmitter()
-
-  @Input()
-  title = $localize`Select`
-
-  @Input()
-  message = $localize`Please select an object`
-
-  @Input()
-  objects: ObjectWithId[] = []
-
-  selected: number
-
-  cancelClicked() {
-    this.activeModal.close()
-  }
-}
diff --git a/src-ui/src/app/components/common/toast/toast.component.html b/src-ui/src/app/components/common/toast/toast.component.html
index ede75ddea..fc8e85e9c 100644
--- a/src-ui/src/app/components/common/toast/toast.component.html
+++ b/src-ui/src/app/components/common/toast/toast.component.html
@@ -33,7 +33,7 @@
                 }
                 <div class="row">
                     <div class="col offset-sm-3">
-                    <button class="btn btn-sm btn-outline-dark" (click)="copyError(toast.error)">
+                    <button class="btn btn-sm btn-outline-secondary" (click)="copyError(toast.error)">
                         @if (!copied) {
                         <i-bs name="clipboard"></i-bs>&nbsp;
                         }
diff --git a/src-ui/src/app/components/document-list/save-view-config-dialog/save-view-config-dialog.component.html b/src-ui/src/app/components/document-list/save-view-config-dialog/save-view-config-dialog.component.html
index 91db10411..acfb15c84 100644
--- a/src-ui/src/app/components/document-list/save-view-config-dialog/save-view-config-dialog.component.html
+++ b/src-ui/src/app/components/document-list/save-view-config-dialog/save-view-config-dialog.component.html
@@ -17,7 +17,7 @@
     }
   </div>
   <div class="modal-footer">
-    <button type="button" class="btn btn-outline-dark" (click)="cancel()" i18n [disabled]="!buttonsEnabled">Cancel</button>
+    <button type="button" class="btn btn-outline-secondary" (click)="cancel()" i18n [disabled]="!buttonsEnabled">Cancel</button>
     <button type="submit" class="btn btn-primary" i18n [disabled]="!buttonsEnabled">Save</button>
   </div>
 </form>
diff --git a/src-ui/src/theme.scss b/src-ui/src/theme.scss
index d7cfa5628..cc60d3851 100644
--- a/src-ui/src/theme.scss
+++ b/src-ui/src/theme.scss
@@ -291,10 +291,6 @@ $form-check-radio-checked-bg-image-dark: url("data:image/svg+xml,<svg xmlns='htt
     color: var(--pngx-primary-text-contrast);
   }
 
-  .toast .btn-outline-dark:hover {
-    color: var(--bs-body-color)
-  }
-
   .dropdown-item {
     --bs-dropdown-color: var(--bs-body-color);
     --pngx-bg-darker: var(--pngx-bg-alt);