Use HttpResponseNotFound

This commit is contained in:
shamoon 2024-11-13 08:22:39 -08:00
parent c7c651dcba
commit 1033deefaf
3 changed files with 5 additions and 4 deletions

View File

@ -637,7 +637,7 @@ class TestApiUser(DirectoriesMixin, APITestCase):
response = self.client.post( response = self.client.post(
f"{self.ENDPOINT}{user1.pk}/deactivate_totp/", f"{self.ENDPOINT}{user1.pk}/deactivate_totp/",
) )
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST) self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)
regular_user = User.objects.create_user(username="regular_user") regular_user = User.objects.create_user(username="regular_user")
regular_user.user_permissions.add( regular_user.user_permissions.add(

View File

@ -378,4 +378,4 @@ class TestApiTOTPViews(APITestCase):
response = self.client.delete( response = self.client.delete(
self.ENDPOINT, self.ENDPOINT,
) )
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST) self.assertEqual(response.status_code, status.HTTP_404_NOT_FOUND)

View File

@ -15,6 +15,7 @@ from django.db.models.functions import Lower
from django.http import HttpResponse from django.http import HttpResponse
from django.http import HttpResponseBadRequest from django.http import HttpResponseBadRequest
from django.http import HttpResponseForbidden from django.http import HttpResponseForbidden
from django.http import HttpResponseNotFound
from django.views.generic import View from django.views.generic import View
from django_filters.rest_framework import DjangoFilterBackend from django_filters.rest_framework import DjangoFilterBackend
from rest_framework.authtoken.models import Token from rest_framework.authtoken.models import Token
@ -124,7 +125,7 @@ class UserViewSet(ModelViewSet):
delete_and_cleanup(request, authenticator) delete_and_cleanup(request, authenticator)
return Response(True) return Response(True)
else: else:
return HttpResponseBadRequest("TOTP not found") return HttpResponseNotFound("TOTP not found")
class GroupViewSet(ModelViewSet): class GroupViewSet(ModelViewSet):
@ -238,7 +239,7 @@ class TOTPView(GenericAPIView):
delete_and_cleanup(request, authenticator) delete_and_cleanup(request, authenticator)
return Response(True) return Response(True)
else: else:
return HttpResponseBadRequest("TOTP not found") return HttpResponseNotFound("TOTP not found")
class GenerateAuthTokenView(GenericAPIView): class GenerateAuthTokenView(GenericAPIView):