From 26900e07669fa9e234ba1ca92aa7340f88fc6e22 Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Thu, 18 Jan 2024 06:58:41 -0800
Subject: [PATCH] Fix: doc link removal before assigning value (#5451)

---
 src/documents/serialisers.py | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py
index 34d842443..942d22fe5 100644
--- a/src/documents/serialisers.py
+++ b/src/documents/serialisers.py
@@ -670,7 +670,10 @@ class DocumentSerializer(
             for custom_field_instance in instance.custom_fields.filter(
                 field__data_type=CustomField.FieldDataType.DOCUMENTLINK,
             ):
-                if custom_field_instance.field not in incoming_custom_fields:
+                if (
+                    custom_field_instance.field not in incoming_custom_fields
+                    and custom_field_instance.value is not None
+                ):
                     # Doc link field is being removed entirely
                     for doc_id in custom_field_instance.value:
                         CustomFieldInstanceSerializer.remove_doclink(