From 364df5c050c4be7fa72f9ef49bcfedf8869e050e Mon Sep 17 00:00:00 2001 From: Michael Shamoon <4887959+nikonratm@users.noreply.github.com> Date: Thu, 10 Dec 2020 15:37:56 -0800 Subject: [PATCH] Fix toggling off active items --- .../app/components/filter-editor/filter-editor.component.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src-ui/src/app/components/filter-editor/filter-editor.component.ts b/src-ui/src/app/components/filter-editor/filter-editor.component.ts index d45732717..d3e8eb244 100644 --- a/src-ui/src/app/components/filter-editor/filter-editor.component.ts +++ b/src-ui/src/app/components/filter-editor/filter-editor.component.ts @@ -127,9 +127,9 @@ export class FilterEditorComponent implements OnInit, AfterViewInit { let filterRuleType: FilterRuleType = FILTER_RULE_TYPES.find(t => t.id == filterRuleTypeID) let existingRule = filterRules.find(rule => rule.type.id == filterRuleType.id) - if (existingRule && existingRule.value == item.id && filterRuleType.id == FILTER_HAS_TAG) { + if (existingRule && existingRule.value == item.id) { filterRules.splice(filterRules.indexOf(existingRule), 1) - } else if (existingRule && filterRuleType.id == FILTER_HAS_TAG) { + } else if (existingRule && filterRuleType.id == FILTER_HAS_TAG) { filterRules.push({type: FILTER_RULE_TYPES.find(t => t.id == filterRuleType.id), value: item.id}) } else if (existingRule && existingRule.value == item.id) { return