From 52480e0bc41720d17ad930585ba76cf201a946bd Mon Sep 17 00:00:00 2001 From: Michael Shamoon <4887959+shamoon@users.noreply.github.com> Date: Thu, 12 May 2022 20:34:32 -0700 Subject: [PATCH 1/2] Use explicit plural strings on management pages --- .../manage/correspondent-list/correspondent-list.component.ts | 1 + .../manage/document-type-list/document-type-list.component.ts | 1 + .../manage/management-list/management-list.component.html | 4 ++-- .../manage/management-list/management-list.component.ts | 1 + .../src/app/components/manage/tag-list/tag-list.component.ts | 1 + 5 files changed, 6 insertions(+), 2 deletions(-) diff --git a/src-ui/src/app/components/manage/correspondent-list/correspondent-list.component.ts b/src-ui/src/app/components/manage/correspondent-list/correspondent-list.component.ts index 6a963fbab..9eb05758c 100644 --- a/src-ui/src/app/components/manage/correspondent-list/correspondent-list.component.ts +++ b/src-ui/src/app/components/manage/correspondent-list/correspondent-list.component.ts @@ -31,6 +31,7 @@ export class CorrespondentListComponent extends ManagementListComponent + @@ -71,6 +71,6 @@
-
{collectionSize, plural, =1 {One {{typeName}}} other {{{collectionSize || 0}} total {{typeName}}s}}
+
{collectionSize, plural, =1 {One {{typeName}}} other {{{collectionSize || 0}} total {{typeNamePlural}}}}
diff --git a/src-ui/src/app/components/manage/management-list/management-list.component.ts b/src-ui/src/app/components/manage/management-list/management-list.component.ts index 0768d7c04..89218f80b 100644 --- a/src-ui/src/app/components/manage/management-list/management-list.component.ts +++ b/src-ui/src/app/components/manage/management-list/management-list.component.ts @@ -45,6 +45,7 @@ export abstract class ManagementListComponent private queryParamsService: QueryParamsService, protected filterRuleType: number, public typeName: string, + public typeNamePlural: string, public extraColumns: ManagementListColumn[] ) {} diff --git a/src-ui/src/app/components/manage/tag-list/tag-list.component.ts b/src-ui/src/app/components/manage/tag-list/tag-list.component.ts index c1dd98e52..cbb47d48e 100644 --- a/src-ui/src/app/components/manage/tag-list/tag-list.component.ts +++ b/src-ui/src/app/components/manage/tag-list/tag-list.component.ts @@ -28,6 +28,7 @@ export class TagListComponent extends ManagementListComponent { queryParamsService, FILTER_HAS_TAGS_ALL, $localize`tag`, + $localize`tags`, [ { key: 'color', From 5061feb7bcd111930dd10d71aef716acfc1903fc Mon Sep 17 00:00:00 2001 From: Michael Shamoon <4887959+shamoon@users.noreply.github.com> Date: Thu, 12 May 2022 20:39:04 -0700 Subject: [PATCH 2/2] Update messages.xlf --- src-ui/messages.xlf | 47 ++++++++++++++++++++++++++++++++------------- 1 file changed, 34 insertions(+), 13 deletions(-) diff --git a/src-ui/messages.xlf b/src-ui/messages.xlf index a396a1519..0a2181cba 100644 --- a/src-ui/messages.xlf +++ b/src-ui/messages.xlf @@ -818,7 +818,7 @@ src/app/components/manage/tag-list/tag-list.component.ts - 34 + 35 @@ -1209,7 +1209,7 @@ src/app/components/manage/management-list/management-list.component.ts - 156 + 157 src/app/components/manage/settings/settings.component.html @@ -1462,7 +1462,7 @@ src/app/components/manage/management-list/management-list.component.ts - 152 + 153 @@ -2092,18 +2092,25 @@ 33 + + correspondents + + src/app/components/manage/correspondent-list/correspondent-list.component.ts + 34 + + Last used src/app/components/manage/correspondent-list/correspondent-list.component.ts - 37 + 38 Do you really want to delete the correspondent ""? src/app/components/manage/correspondent-list/correspondent-list.component.ts - 47 + 48 @@ -2113,11 +2120,18 @@ 30 + + document types + + src/app/components/manage/document-type-list/document-type-list.component.ts + 31 + + Do you really want to delete the document type ""? src/app/components/manage/document-type-list/document-type-list.component.ts - 36 + 37 @@ -2214,8 +2228,8 @@ 44 - - {VAR_PLURAL, plural, =1 {One } other { total s}} + + {VAR_PLURAL, plural, =1 {One } other { total }} src/app/components/manage/management-list/management-list.component.html 74 @@ -2233,7 +2247,7 @@ Automatic src/app/components/manage/management-list/management-list.component.ts - 86 + 87 src/app/data/matching-model.ts @@ -2244,14 +2258,14 @@ Do you really want to delete the ? src/app/components/manage/management-list/management-list.component.ts - 139 + 140 Associated documents will not be deleted. src/app/components/manage/management-list/management-list.component.ts - 154 + 155 @@ -2260,7 +2274,7 @@ )"/> src/app/components/manage/management-list/management-list.component.ts - 167,169 + 168,170 @@ -2531,11 +2545,18 @@ 30 + + tags + + src/app/components/manage/tag-list/tag-list.component.ts + 31 + + Do you really want to delete the tag ""? src/app/components/manage/tag-list/tag-list.component.ts - 45 + 46