Try again, properly hopefully

src/documents/management/commands/document_consumer.py

@@ -317,10 +317,8 @@ class Command(BaseCommand):
 
                 # Check the files against the timeout
                 still_waiting = {}
-                for filepath in notified_files.items():
-                    # Time of the last inotify event for this file
-                    last_event_time = notified_files[filepath]
-
+                # last_event_time is time of the last inotify event for this file
+                for filepath, last_event_time in notified_files.items():
                     # Current time - last time over the configured timeout
                     waited_long_enough = (
                         monotonic() - last_event_time

src/documents/management/commands/document_exporter.py

@@ -294,7 +294,7 @@ class Command(CryptMixin, BaseCommand):
             manifest_dict = {}
 
             # Build an overall manifest
-            for key in manifest_key_to_object_query.items():
+            for key, _ in manifest_key_to_object_query.items():
                 manifest_dict[key] = json.loads(
                     serializers.serialize("json", manifest_key_to_object_query[key]),
                 )
@@ -370,7 +370,7 @@ class Command(CryptMixin, BaseCommand):
 
         # 4.1 write primary manifest to target folder
         manifest = []
-        for key in manifest_dict.items():
+        for key, _ in manifest_dict.items():
             manifest.extend(manifest_dict[key])
         manifest_path = (self.target / "manifest.json").resolve()
         self.check_and_write_json(

src/documents/serialisers.py

@@ -160,7 +160,7 @@ class SetPermissionsMixin:
             },
         }
         if set_permissions is not None:
-            for action in permissions_dict.items():
+            for action, _ in permissions_dict.items():
                 if action in set_permissions:
                     users = set_permissions[action]["users"]
                     permissions_dict[action]["users"] = self._validate_user_ids(users)