From 47ddb266dd2eca84d7c2eef7db70a02b043a8065 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Sun, 18 Jan 2026 14:49:43 -0800 Subject: [PATCH] Some random cleanups --- src/documents/consumer.py | 9 +-------- src/documents/serialisers.py | 7 ++----- 2 files changed, 3 insertions(+), 13 deletions(-) diff --git a/src/documents/consumer.py b/src/documents/consumer.py index 2dc7fd7b7..3cd930896 100644 --- a/src/documents/consumer.py +++ b/src/documents/consumer.py @@ -806,14 +806,7 @@ class ConsumerPreflightPlugin( or str(duplicate.pk) ) - try: - Path(self.input_doc.original_file).unlink() - except FileNotFoundError: - pass - except Exception as exc: # pragma: no cover - self.log.warning( - f"Could not delete duplicate file {self.input_doc.original_file}: {exc}", - ) + Path(self.input_doc.original_file).unlink() failure_msg = ( f"Not consuming {self.filename}: " diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py index 494142b3a..d564171f0 100644 --- a/src/documents/serialisers.py +++ b/src/documents/serialisers.py @@ -2161,7 +2161,8 @@ class TasksViewSerializer(OwnedObjectSerializer): return result - def _get_duplicate_documents(self, obj): + @extend_schema_field(DuplicateDocumentSummarySerializer(many=True)) + def get_duplicate_documents(self, obj): if not hasattr(self, "_duplicate_documents_cache"): self._duplicate_documents_cache = {} cache = self._duplicate_documents_cache @@ -2182,10 +2183,6 @@ class TasksViewSerializer(OwnedObjectSerializer): cache[obj.pk] = list(duplicates.values("id", "title", "deleted_at")) return cache[obj.pk] - @extend_schema_field(DuplicateDocumentSummarySerializer(many=True)) - def get_duplicate_documents(self, obj): - return self._get_duplicate_documents(obj) - class RunTaskViewSerializer(serializers.Serializer): task_name = serializers.ChoiceField(