From 4948438378e05bbb5442eb9ec4f714d5e94bfbde Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Sun, 25 Feb 2024 16:59:29 -0800 Subject: [PATCH] Fix: intermittent save & close warnings in v2.5.3 (#5838) --- .../document-detail/document-detail.component.ts | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src-ui/src/app/components/document-detail/document-detail.component.ts b/src-ui/src/app/components/document-detail/document-detail.component.ts index 6630f0ad6..4eae47615 100644 --- a/src-ui/src/app/components/document-detail/document-detail.component.ts +++ b/src-ui/src/app/components/document-detail/document-detail.component.ts @@ -634,11 +634,14 @@ export class DocumentDetailComponent // in case data changed while saving eg removing inbox_tags this.documentForm.patchValue(docValues) this.store.next(this.documentForm.value) + this.openDocumentService.setDirty(this.document, false) this.toastService.showInfo($localize`Document saved successfully.`) - close && this.close() this.networkActive = false this.error = null - this.openDocumentService.refreshDocument(this.documentId) + close && + this.close(() => + this.openDocumentService.refreshDocument(this.documentId) + ) }, error: (error) => { this.networkActive = false @@ -693,12 +696,13 @@ export class DocumentDetailComponent }) } - close() { + close(closedCallback: () => void = null) { this.openDocumentService .closeDocument(this.document) .pipe(first()) .subscribe((closed) => { if (!closed) return + if (closedCallback) closedCallback() if (this.documentListViewService.activeSavedViewId) { this.router.navigate([ 'view',