Code cleanup

This commit is contained in:
Michael Shamoon 2020-12-13 20:37:13 -08:00
parent 9bfc92cf79
commit 54d90a4c4b
2 changed files with 11 additions and 20 deletions

View File

@ -113,17 +113,17 @@ export class DocumentListComponent implements OnInit {
} }
clickTag(tagID: number) { clickTag(tagID: number) {
this.filterEditorService.toggleFilterByTagID(tagID) this.filterEditorService.toggleFilterByTag(tagID)
this.applyFilterRules() this.applyFilterRules()
} }
clickCorrespondent(correspondentID: number) { clickCorrespondent(correspondentID: number) {
this.filterEditorService.toggleFilterByCorrespondentID(correspondentID) this.filterEditorService.toggleFilterByCorrespondent(correspondentID)
this.applyFilterRules() this.applyFilterRules()
} }
clickDocumentType(documentTypeID: number) { clickDocumentType(documentTypeID: number) {
this.filterEditorService.toggleFilterByDocumentTypeID(documentTypeID) this.filterEditorService.toggleFilterByDocumentType(documentTypeID)
this.applyFilterRules() this.applyFilterRules()
} }

View File

@ -76,28 +76,19 @@ export class FilterEditorViewService {
return this.documentTypes?.filter(dt => documentTypeRules.find(dtr => dtr.value == dt.id)) return this.documentTypes?.filter(dt => documentTypeRules.find(dtr => dtr.value == dt.id))
} }
toggleFilterByTag(tag: PaperlessTag) { toggleFilterByTag(tag: PaperlessTag | number) {
if (typeof tag == 'number') tag = this.tags?.find(t => t.id == tag)
this.toggleFilterByItem(tag, FILTER_HAS_TAG) this.toggleFilterByItem(tag, FILTER_HAS_TAG)
} }
toggleFilterByCorrespondent(tag: PaperlessCorrespondent) { toggleFilterByCorrespondent(correspondent: PaperlessCorrespondent | number) {
this.toggleFilterByItem(tag, FILTER_CORRESPONDENT) if (typeof correspondent == 'number') correspondent = this.correspondents?.find(t => t.id == correspondent)
this.toggleFilterByItem(correspondent, FILTER_CORRESPONDENT)
} }
toggleFilterByDocumentType(tag: PaperlessDocumentType) { toggleFilterByDocumentType(documentType: PaperlessDocumentType | number) {
this.toggleFilterByItem(tag, FILTER_DOCUMENT_TYPE) if (typeof documentType == 'number') documentType = this.documentTypes?.find(t => t.id == documentType)
} this.toggleFilterByItem(documentType, FILTER_DOCUMENT_TYPE)
toggleFilterByTagID(tagID: number) {
this.toggleFilterByTag(this.tags?.find(t => t.id == tagID))
}
toggleFilterByCorrespondentID(correspondentID: number) {
this.toggleFilterByCorrespondent(this.correspondents?.find(t => t.id == correspondentID))
}
toggleFilterByDocumentTypeID(documentTypeID: number) {
this.toggleFilterByDocumentType(this.documentTypes?.find(t => t.id == documentTypeID))
} }
private toggleFilterByItem(item: ObjectWithId, filterRuleTypeID: number) { private toggleFilterByItem(item: ObjectWithId, filterRuleTypeID: number) {