From 55ddcd753e62d07208e97499051e7d3b9f7833c3 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Wed, 17 Dec 2025 23:25:49 -0800 Subject: [PATCH] Test --- .../preview-popup.component.html | 2 +- .../preview-popup/preview-popup.component.ts | 2 -- .../saved-view-widget.component.spec.ts | 2 -- .../document-detail.component.html | 8 ++--- .../document-detail.component.ts | 2 -- .../document-card-large.component.spec.ts | 2 -- src-ui/src/app/pipes/safeurl.pipe.spec.ts | 32 ------------------- src-ui/src/app/pipes/safeurl.pipe.ts | 17 ---------- 8 files changed, 5 insertions(+), 62 deletions(-) delete mode 100644 src-ui/src/app/pipes/safeurl.pipe.spec.ts delete mode 100644 src-ui/src/app/pipes/safeurl.pipe.ts diff --git a/src-ui/src/app/components/common/preview-popup/preview-popup.component.html b/src-ui/src/app/components/common/preview-popup/preview-popup.component.html index 7dc0ee708..4e05a74de 100644 --- a/src-ui/src/app/components/common/preview-popup/preview-popup.component.html +++ b/src-ui/src/app/components/common/preview-popup/preview-popup.component.html @@ -14,7 +14,7 @@ @if (previewText) {
{{previewText}}
} @else { - + } } @else { @if (requiresPassword) { diff --git a/src-ui/src/app/components/common/preview-popup/preview-popup.component.ts b/src-ui/src/app/components/common/preview-popup/preview-popup.component.ts index 70161a02a..423b449ec 100644 --- a/src-ui/src/app/components/common/preview-popup/preview-popup.component.ts +++ b/src-ui/src/app/components/common/preview-popup/preview-popup.component.ts @@ -7,7 +7,6 @@ import { first, Subject, takeUntil } from 'rxjs' import { Document } from 'src/app/data/document' import { SETTINGS_KEYS } from 'src/app/data/ui-settings' import { DocumentTitlePipe } from 'src/app/pipes/document-title.pipe' -import { SafeUrlPipe } from 'src/app/pipes/safeurl.pipe' import { DocumentService } from 'src/app/services/rest/document.service' import { SettingsService } from 'src/app/services/settings.service' @@ -19,7 +18,6 @@ import { SettingsService } from 'src/app/services/settings.service' NgbPopoverModule, DocumentTitlePipe, PdfViewerModule, - SafeUrlPipe, NgxBootstrapIconsModule, ], }) diff --git a/src-ui/src/app/components/dashboard/widgets/saved-view-widget/saved-view-widget.component.spec.ts b/src-ui/src/app/components/dashboard/widgets/saved-view-widget/saved-view-widget.component.spec.ts index 621a90491..95d976ac2 100644 --- a/src-ui/src/app/components/dashboard/widgets/saved-view-widget/saved-view-widget.component.spec.ts +++ b/src-ui/src/app/components/dashboard/widgets/saved-view-widget/saved-view-widget.component.spec.ts @@ -32,7 +32,6 @@ import { IfPermissionsDirective } from 'src/app/directives/if-permissions.direct import { PermissionsGuard } from 'src/app/guards/permissions.guard' import { CustomDatePipe } from 'src/app/pipes/custom-date.pipe' import { DocumentTitlePipe } from 'src/app/pipes/document-title.pipe' -import { SafeUrlPipe } from 'src/app/pipes/safeurl.pipe' import { DocumentListViewService } from 'src/app/services/document-list-view.service' import { PermissionsService } from 'src/app/services/permissions.service' import { CustomFieldsService } from 'src/app/services/rest/custom-fields.service' @@ -128,7 +127,6 @@ describe('SavedViewWidgetComponent', () => { IfPermissionsDirective, CustomDatePipe, DocumentTitlePipe, - SafeUrlPipe, PreviewPopupComponent, CustomFieldDisplayComponent, ], diff --git a/src-ui/src/app/components/document-detail/document-detail.component.html b/src-ui/src/app/components/document-detail/document-detail.component.html index d8cd2d756..acedc4a5c 100644 --- a/src-ui/src/app/components/document-detail/document-detail.component.html +++ b/src-ui/src/app/components/document-detail/document-detail.component.html @@ -379,7 +379,7 @@
@if (showThumbnailOverlay) { - Document loading... + Document loading... }
@@ -406,7 +406,7 @@
} @else { - + } } @case (ContentRenderType.Text) { @@ -414,7 +414,7 @@ } @case (ContentRenderType.Image) {
- {{title}} + {{title}}
} @case (ContentRenderType.TIFF) { @@ -427,7 +427,7 @@ } } @case (ContentRenderType.Other) { - + } } @if (requiresPassword) { diff --git a/src-ui/src/app/components/document-detail/document-detail.component.ts b/src-ui/src/app/components/document-detail/document-detail.component.ts index 9c0c84592..4d7a0bdea 100644 --- a/src-ui/src/app/components/document-detail/document-detail.component.ts +++ b/src-ui/src/app/components/document-detail/document-detail.component.ts @@ -60,7 +60,6 @@ import { IfPermissionsDirective } from 'src/app/directives/if-permissions.direct import { CustomDatePipe } from 'src/app/pipes/custom-date.pipe' import { DocumentTitlePipe } from 'src/app/pipes/document-title.pipe' import { FileSizePipe } from 'src/app/pipes/file-size.pipe' -import { SafeUrlPipe } from 'src/app/pipes/safeurl.pipe' import { ComponentRouterService } from 'src/app/services/component-router.service' import { DocumentListViewService } from 'src/app/services/document-list-view.service' import { HotKeyService } from 'src/app/services/hot-key.service' @@ -169,7 +168,6 @@ export enum ZoomSetting { FormsModule, ReactiveFormsModule, NgTemplateOutlet, - SafeUrlPipe, NgbNavModule, NgbDropdownModule, NgxBootstrapIconsModule, diff --git a/src-ui/src/app/components/document-list/document-card-large/document-card-large.component.spec.ts b/src-ui/src/app/components/document-list/document-card-large/document-card-large.component.spec.ts index 4d62c6a0a..78f089761 100644 --- a/src-ui/src/app/components/document-list/document-card-large/document-card-large.component.spec.ts +++ b/src-ui/src/app/components/document-list/document-card-large/document-card-large.component.spec.ts @@ -14,7 +14,6 @@ import { IfPermissionsDirective } from 'src/app/directives/if-permissions.direct import { CustomDatePipe } from 'src/app/pipes/custom-date.pipe' import { DocumentTitlePipe } from 'src/app/pipes/document-title.pipe' import { IsNumberPipe } from 'src/app/pipes/is-number.pipe' -import { SafeUrlPipe } from 'src/app/pipes/safeurl.pipe' import { CustomFieldDisplayComponent } from '../../common/custom-field-display/custom-field-display.component' import { PreviewPopupComponent } from '../../common/preview-popup/preview-popup.component' import { DocumentCardLargeComponent } from './document-card-large.component' @@ -53,7 +52,6 @@ describe('DocumentCardLargeComponent', () => { DocumentTitlePipe, CustomDatePipe, IfPermissionsDirective, - SafeUrlPipe, IsNumberPipe, PreviewPopupComponent, CustomFieldDisplayComponent, diff --git a/src-ui/src/app/pipes/safeurl.pipe.spec.ts b/src-ui/src/app/pipes/safeurl.pipe.spec.ts deleted file mode 100644 index b1fc16885..000000000 --- a/src-ui/src/app/pipes/safeurl.pipe.spec.ts +++ /dev/null @@ -1,32 +0,0 @@ -import { TestBed } from '@angular/core/testing' -import { BrowserModule, DomSanitizer } from '@angular/platform-browser' -import { SafeUrlPipe } from './safeurl.pipe' - -describe('SafeUrlPipe', () => { - let pipe: SafeUrlPipe - - beforeEach(() => { - TestBed.configureTestingModule({ - providers: [SafeUrlPipe], - imports: [BrowserModule], - }) - pipe = TestBed.inject(SafeUrlPipe) - }) - - it('should bypass security and trust the url', () => { - const url = 'https://example.com' - const domSanitizer = TestBed.inject(DomSanitizer) - const sanitizerSpy = jest.spyOn( - domSanitizer, - 'bypassSecurityTrustResourceUrl' - ) - - let safeResourceUrl = pipe.transform(url) - expect(safeResourceUrl).not.toBeNull() - expect(sanitizerSpy).toHaveBeenCalled() - - safeResourceUrl = pipe.transform(null) - expect(safeResourceUrl).not.toBeNull() - expect(sanitizerSpy).toHaveBeenCalled() - }) -}) diff --git a/src-ui/src/app/pipes/safeurl.pipe.ts b/src-ui/src/app/pipes/safeurl.pipe.ts deleted file mode 100644 index 37fdd743b..000000000 --- a/src-ui/src/app/pipes/safeurl.pipe.ts +++ /dev/null @@ -1,17 +0,0 @@ -import { Pipe, PipeTransform, inject } from '@angular/core' -import { DomSanitizer } from '@angular/platform-browser' - -@Pipe({ - name: 'safeUrl', -}) -export class SafeUrlPipe implements PipeTransform { - private sanitizer = inject(DomSanitizer) - - transform(url) { - if (url == null) { - return this.sanitizer.bypassSecurityTrustResourceUrl('') - } else { - return this.sanitizer.bypassSecurityTrustResourceUrl(url) - } - } -}