From 57a5df1fce5379b08eb4037d5c38dfcb31f81dab Mon Sep 17 00:00:00 2001
From: Robert <RobertStreitfeld@gmx.de>
Date: Sun, 7 Mar 2021 16:04:45 +0100
Subject: [PATCH] fix writable check for NFS mounts
For some reason, os.access(directory, os.W_OK | os.X_OK) does not work correctly on NFS mounts.
After some research, found out that the only secure and portable way to check for write access, is to touch a file.
---
src/paperless/checks.py | 22 ++++++++++++++++------
1 file changed, 16 insertions(+), 6 deletions(-)
diff --git a/src/paperless/checks.py b/src/paperless/checks.py
index df4d45e38..0d11d8a90 100644
--- a/src/paperless/checks.py
+++ b/src/paperless/checks.py
@@ -1,5 +1,6 @@
import os
import shutil
+import stat
from django.conf import settings
from django.core.checks import Error, Warning, register
@@ -16,16 +17,25 @@ writeable_hint = (
def path_check(var, directory):
messages = []
if directory:
- if not os.path.exists(directory):
+ if not os.path.isdir(directory):
messages.append(Error(
exists_message.format(var),
exists_hint.format(directory)
))
- elif not os.access(directory, os.W_OK | os.X_OK):
- messages.append(Warning(
- writeable_message.format(var),
- writeable_hint.format(directory)
- ))
+ else:
+ test_file = os.path.join(directory, '__paperless_write_test__')
+ try:
+ open(test_file, 'w')
+ except PermissionError:
+ messages.append(Error(
+ writeable_message.format(var),
+ writeable_hint.format(
+ f'\n{stat.filemode(os.stat(directory).st_mode)} '
+ f'{directory}\n')
+ ))
+ else:
+ os.remove(test_file)
+
return messages