paradizelost/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2025-04-02 13:45:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix: prune invalid custom fields (#9224)

Browse Source
This commit is contained in:
shamoon 2025-02-25 13:50:15 -08:00 committed by GitHub
parent d364436817
commit 61cb5103ed
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 6 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/documents/serialisers.py
View File

@ -1136,9 +1136,8 @@ class SavedViewSerializer(OwnedObjectSerializer):
): # i.e. check for 'custom_field_' prefix ): # i.e. check for 'custom_field_' prefix
field_id = int(re.search(r"\d+", field)[0]) field_id = int(re.search(r"\d+", field)[0])
if not CustomField.objects.filter(id=field_id).exists(): if not CustomField.objects.filter(id=field_id).exists():
raise serializers.ValidationError( # In case the field was deleted, just remove from the list
f"Invalid field: {field}", attrs["display_fields"].remove(field)
)
elif field not in SavedView.DisplayFields.values: elif field not in SavedView.DisplayFields.values:
raise serializers.ValidationError( raise serializers.ValidationError(
f"Invalid field: {field}", f"Invalid field: {field}",

6
src/documents/tests/test_api_documents.py
View File

@ -1911,7 +1911,7 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
], ],
) )
# Custom field not found # Custom field not found, removed from list
response = self.client.patch( response = self.client.patch(
f"/api/saved_views/{v1.id}/", f"/api/saved_views/{v1.id}/",
{ {
@ -1923,7 +1923,9 @@ class TestDocumentApi(DirectoriesMixin, DocumentConsumeDelayMixin, APITestCase):
}, },
format="json", format="json",
) )
self.assertEqual(response.status_code, status.HTTP_400_BAD_REQUEST) self.assertEqual(response.status_code, status.HTTP_200_OK)
v1.refresh_from_db()
self.assertNotIn(SavedView.DisplayFields.CUSTOM_FIELD % 99, v1.display_fields)
def test_get_logs(self): def test_get_logs(self):
log_data = "test\ntest2\n" log_data = "test\ntest2\n"