From 76001105b87a18377069a1c193d0abdd947d58c6 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Thu, 28 Dec 2023 11:57:46 -0800 Subject: [PATCH] Fix saving doc links with no value (#5144) --- src/documents/serialisers.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py index c6837b247..62e7d75b4 100644 --- a/src/documents/serialisers.py +++ b/src/documents/serialisers.py @@ -512,11 +512,17 @@ class CustomFieldInstanceSerializer(serializers.ModelSerializer): field=field, document=document, ).first() - if current_field_instance is not None: + if ( + current_field_instance is not None + and current_field_instance.value is not None + ): for doc_id in current_field_instance.value: if doc_id not in target_doc_ids: self.remove_doclink(document, field, doc_id) + if target_doc_ids is None: + target_doc_ids = [] + # Create an instance if target doc doesnt have this field or append it to an existing one existing_custom_field_instances = { custom_field.document_id: custom_field