Apply suggestions from code review

src/documents/migrations/1057_alter_customfieldinstance_value_select.py

@@ -15,21 +15,22 @@ def migrate_customfield_selects(apps, schema_editor):
     CustomField = apps.get_model("documents", "CustomField")
 
     with transaction.atomic():
-        for custom_field in CustomField.objects.all():
+        for custom_field in CustomField.objects.filter(
-            if custom_field.data_type == "select":  # CustomField.FieldDataType.SELECT
+            data_type="select",
-                old_select_options = custom_field.extra_data["select_options"]
+        ):  # CustomField.FieldDataType.SELECT
-                custom_field.extra_data["select_options"] = [
+            old_select_options = custom_field.extra_data["select_options"]
-                    {"id": get_random_string(16), "label": value}
+            custom_field.extra_data["select_options"] = [
-                    for value in old_select_options
+                {"id": get_random_string(16), "label": value}
-                ]
+                for value in old_select_options
-                custom_field.save()
+            ]
+            custom_field.save()
 
-                for instance in CustomFieldInstance.objects.filter(field=custom_field):
+            for instance in CustomFieldInstance.objects.filter(field=custom_field):
-                    if instance.value_select:
+                if instance.value_select:
-                        instance.value_select = custom_field.extra_data[
+                    instance.value_select = custom_field.extra_data["select_options"][
-                            "select_options"
+                        int(instance.value_select)
-                        ][int(instance.value_select)]["id"]
+                    ]["id"]
-                        instance.save()
+                    instance.save()
 
 
 def reverse_migrate_customfield_selects(apps, schema_editor):

src/documents/serialisers.py

@@ -552,7 +552,7 @@ class CustomFieldSerializer(serializers.ModelSerializer):
                 )
             # labels are valid, generate ids if not present
             for option in attrs["extra_data"]["select_options"]:
-                if "id" not in option or option["id"] is None:
+                if option.get("id") is None:
                     option["id"] = get_random_string(length=16)
         elif (
             "data_type" in attrs