paradizelost/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2025-05-01 11:19:32 -05:00
Code Issues Packages Projects Releases Wiki Activity

Apply suggestions from code review

Browse Source
This commit is contained in:
shamoon 2024-12-01 09:52:05 -08:00
parent 65bc65ac02
commit 7756d49e5c
2 changed files with 16 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
src/documents/migrations/1057_alter_customfieldinstance_value_select.py
View File

@ -15,21 +15,22 @@ def migrate_customfield_selects(apps, schema_editor):
CustomField = apps.get_model("documents", "CustomField")
with transaction.atomic():
for custom_field in CustomField.objects.all():
if custom_field.data_type == "select": # CustomField.FieldDataType.SELECT
old_select_options = custom_field.extra_data["select_options"]
custom_field.extra_data["select_options"] = [
{"id": get_random_string(16), "label": value}
for value in old_select_options
]
custom_field.save()
for custom_field in CustomField.objects.filter(
data_type="select",
): # CustomField.FieldDataType.SELECT
old_select_options = custom_field.extra_data["select_options"]
custom_field.extra_data["select_options"] = [
{"id": get_random_string(16), "label": value}
for value in old_select_options
]
custom_field.save()
for instance in CustomFieldInstance.objects.filter(field=custom_field):
if instance.value_select:
instance.value_select = custom_field.extra_data[
"select_options"
][int(instance.value_select)]["id"]
instance.save()
for instance in CustomFieldInstance.objects.filter(field=custom_field):
if instance.value_select:
instance.value_select = custom_field.extra_data["select_options"][
int(instance.value_select)
]["id"]
instance.save()
def reverse_migrate_customfield_selects(apps, schema_editor):

2
src/documents/serialisers.py
View File

@ -552,7 +552,7 @@ class CustomFieldSerializer(serializers.ModelSerializer):
)
# labels are valid, generate ids if not present
for option in attrs["extra_data"]["select_options"]:
if "id" not in option or option["id"] is None:
if option.get("id") is None:
option["id"] = get_random_string(length=16)
elif (
"data_type" in attrs