From 7996eff876118225ef8104c302a18142ba7b3d6d Mon Sep 17 00:00:00 2001 From: tsia Date: Sun, 5 Jan 2025 17:36:15 +0100 Subject: [PATCH] fix browser cache for documents api endpoints no Cache-Control: max-age for thumb/preview Cache-Control: no-cache for all endpoints which already serve Etag and Last-Modified headers --- src/documents/views.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/src/documents/views.py b/src/documents/views.py index 4e2e4a8bf..fe149798b 100644 --- a/src/documents/views.py +++ b/src/documents/views.py @@ -75,7 +75,6 @@ from documents import index from documents.bulk_download import ArchiveOnlyStrategy from documents.bulk_download import OriginalAndArchiveStrategy from documents.bulk_download import OriginalsOnlyStrategy -from documents.caching import CACHE_50_MINUTES from documents.caching import get_metadata_cache from documents.caching import get_suggestion_cache from documents.caching import refresh_metadata_cache @@ -469,6 +468,7 @@ class DocumentViewSet( return None @action(methods=["get"], detail=True) + @method_decorator(cache_control(no_cache=True)) @method_decorator( condition(etag_func=metadata_etag, last_modified_func=metadata_last_modified), ) @@ -527,6 +527,7 @@ class DocumentViewSet( return Response(meta) @action(methods=["get"], detail=True) + @method_decorator(cache_control(no_cache=True)) @method_decorator( condition( etag_func=suggestions_etag, @@ -577,7 +578,7 @@ class DocumentViewSet( return Response(resp_data) @action(methods=["get"], detail=True) - @method_decorator(cache_control(public=False, max_age=5 * 60)) + @method_decorator(cache_control(no_cache=True)) @method_decorator( condition(etag_func=preview_etag, last_modified_func=preview_last_modified), ) @@ -589,7 +590,7 @@ class DocumentViewSet( raise Http404 @action(methods=["get"], detail=True) - @method_decorator(cache_control(public=False, max_age=CACHE_50_MINUTES)) + @method_decorator(cache_control(no_cache=True)) @method_decorator(last_modified(thumbnail_last_modified)) def thumb(self, request, pk=None): try: