From 7a4666783e6650aedb37b0dd1482c1624d97c59b Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Thu, 13 Feb 2025 20:00:35 -0800
Subject: [PATCH] Fix tests, warning

---
 src/documents/tests/test_api_status.py | 36 ++++++++++++++++++++++++++
 src/documents/views.py                 | 26 +++++++------------
 2 files changed, 46 insertions(+), 16 deletions(-)

diff --git a/src/documents/tests/test_api_status.py b/src/documents/tests/test_api_status.py
index 992dbff64..6bbb4dcb0 100644
--- a/src/documents/tests/test_api_status.py
+++ b/src/documents/tests/test_api_status.py
@@ -209,6 +209,24 @@ class TestSystemStatus(APITestCase):
         self.assertEqual(response.data["tasks"]["classifier_status"], "OK")
         self.assertIsNone(response.data["tasks"]["classifier_error"])
 
+    def test_system_status_classifier_warning(self):
+        """
+        GIVEN:
+            - No classifier task is found
+        WHEN:
+            - The user requests the system status
+        THEN:
+            - The response contains a WARNING classifier status
+        """
+        self.client.force_login(self.user)
+        response = self.client.get(self.ENDPOINT)
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertEqual(
+            response.data["tasks"]["classifier_status"],
+            "WARNING",
+        )
+        self.assertIsNone(response.data["tasks"]["classifier_error"])
+
     def test_system_status_classifier_error(self):
         """
         GIVEN:
@@ -253,6 +271,24 @@ class TestSystemStatus(APITestCase):
         self.assertEqual(response.data["tasks"]["sanity_check_status"], "OK")
         self.assertIsNone(response.data["tasks"]["sanity_check_error"])
 
+    def test_system_status_sanity_check_warning(self):
+        """
+        GIVEN:
+            - No sanity check task is found
+        WHEN:
+            - The user requests the system status
+        THEN:
+            - The response contains a WARNING sanity check status
+        """
+        self.client.force_login(self.user)
+        response = self.client.get(self.ENDPOINT)
+        self.assertEqual(response.status_code, status.HTTP_200_OK)
+        self.assertEqual(
+            response.data["tasks"]["sanity_check_status"],
+            "WARNING",
+        )
+        self.assertIsNone(response.data["tasks"]["sanity_check_error"])
+
     def test_system_status_sanity_check_error(self):
         """
         GIVEN:
diff --git a/src/documents/views.py b/src/documents/views.py
index 8903ff62a..d9bd2f585 100644
--- a/src/documents/views.py
+++ b/src/documents/views.py
@@ -2666,15 +2666,12 @@ class SystemStatusView(PassUserMixin):
             .order_by("-date_done")
             .first()
         )
-
-        classifier_status = (
-            "OK"
-            if last_trained_task is not None
-            and last_trained_task.status == states.SUCCESS
-            else "ERROR"
-        )
+        classifier_status = "OK"
         classifier_error = None
-        if last_trained_task and last_trained_task.status == states.FAILURE:
+        if last_trained_task is None:
+            classifier_status = "WARNING"
+        elif last_trained_task and last_trained_task.status == states.FAILURE:
+            classifier_status = "ERROR"
             classifier_error = last_trained_task.result
         classifier_last_trained = (
             last_trained_task.date_done if last_trained_task else None
@@ -2687,15 +2684,12 @@ class SystemStatusView(PassUserMixin):
             .order_by("-date_done")
             .first()
         )
-
-        sanity_check_status = (
-            "OK"
-            if last_sanity_check is not None
-            and last_sanity_check.status == states.SUCCESS
-            else "ERROR"
-        )
+        sanity_check_status = "OK"
         sanity_check_error = None
-        if last_sanity_check and last_sanity_check.status == states.FAILURE:
+        if last_sanity_check is None:
+            sanity_check_status = "WARNING"
+        elif last_sanity_check and last_sanity_check.status == states.FAILURE:
+            sanity_check_status = "ERROR"
             sanity_check_error = last_sanity_check.result
         sanity_check_last_run = (
             last_sanity_check.date_done if last_sanity_check else None