From 7afc8ceb2428fefcdbb2c4d160c85e09d0f0b9e6 Mon Sep 17 00:00:00 2001 From: Trenton H <797416+stumpylog@users.noreply.github.com> Date: Wed, 28 Jan 2026 14:24:14 -0800 Subject: [PATCH] Change the contract, just take the actual filename, not the file path --- src/documents/plugins/date_parsing/base.py | 3 +-- src/documents/plugins/date_parsing/regex_parser.py | 5 ++--- src/documents/tests/date_parsing/test_date_parsing.py | 1 - 3 files changed, 3 insertions(+), 6 deletions(-) diff --git a/src/documents/plugins/date_parsing/base.py b/src/documents/plugins/date_parsing/base.py index 09e49e30b..93e4cecaa 100644 --- a/src/documents/plugins/date_parsing/base.py +++ b/src/documents/plugins/date_parsing/base.py @@ -4,7 +4,6 @@ from abc import ABC from abc import abstractmethod from collections.abc import Iterator from dataclasses import dataclass -from pathlib import Path import dateparser @@ -90,7 +89,7 @@ class DateParserPluginBase(ABC): return None @abstractmethod - def parse(self, filename: Path, content: str) -> Iterator[datetime.datetime]: + def parse(self, filename: str, content: str) -> Iterator[datetime.datetime]: """ Parses a document's filename and content, yielding valid datetime objects. """ diff --git a/src/documents/plugins/date_parsing/regex_parser.py b/src/documents/plugins/date_parsing/regex_parser.py index 7972efd7f..2df8f9295 100644 --- a/src/documents/plugins/date_parsing/regex_parser.py +++ b/src/documents/plugins/date_parsing/regex_parser.py @@ -1,7 +1,6 @@ import datetime import re from collections.abc import Iterator -from pathlib import Path from re import Match from documents.plugins.date_parsing.base import DateParserPluginBase @@ -51,7 +50,7 @@ class RegexDateParserPlugin(DateParserPluginBase): if date is not None: yield date - def parse(self, filename: Path, content: str) -> Iterator[datetime.datetime]: + def parse(self, filename: str, content: str) -> Iterator[datetime.datetime]: """ Implementation of the abstract parse method. @@ -59,7 +58,7 @@ class RegexDateParserPlugin(DateParserPluginBase): """ if self.config.filename_date_order: yield from self._process_content( - filename.name, + filename, self.config.filename_date_order, ) diff --git a/src/documents/tests/date_parsing/test_date_parsing.py b/src/documents/tests/date_parsing/test_date_parsing.py index f0948324a..ecab2ab76 100644 --- a/src/documents/tests/date_parsing/test_date_parsing.py +++ b/src/documents/tests/date_parsing/test_date_parsing.py @@ -213,7 +213,6 @@ class TestFilterDate: @pytest.mark.date_parsing -@pytest.mark.regex_date_parser class TestRegexDateParser: @pytest.mark.parametrize( ("filename", "content", "expected"),