paradizelost/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2025-10-30 03:56:23 -05:00
Code Issues Packages Projects Releases Wiki Activity

Avoid TOCTOU error by rather catching an exception than checking

Browse Source 
beforehand
This commit is contained in:
Wolf-Bastian Poettner
2020-02-01 20:13:05 +00:00
parent a5518a307c
commit 86de7847cf
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/documents/models.py
View File

@@ -450,9 +450,9 @@ def delete_files(sender, instance, **kwargs):
# Remove the document # Remove the document
old_file = instance.filename_to_path(instance.filename) old_file = instance.filename_to_path(instance.filename)
if os.path.isfile(old_file): try:
os.remove(old_file) os.remove(old_file)
else: except FileNotFoundError:
logger = logging.getLogger(__name__) logger = logging.getLogger(__name__)
logger.warning("Deleted document " + str(instance.id) + " but file " + logger.warning("Deleted document " + str(instance.id) + " but file " +
old_file + " was no longer present") old_file + " was no longer present")