From 88343cabba7fc49d226afe026bd7a6e4cb542731 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Wed, 16 Apr 2025 08:26:43 -0700 Subject: [PATCH] Fix: dont try deleting original that was moved to trash dir --- src/documents/signals/handlers.py | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/documents/signals/handlers.py b/src/documents/signals/handlers.py index ae15992ed..eb5a0b303 100644 --- a/src/documents/signals/handlers.py +++ b/src/documents/signals/handlers.py @@ -349,11 +349,15 @@ def cleanup_document_deletion(sender, instance, **kwargs): ) return - for filename in ( - instance.source_path, + files = ( instance.archive_path, instance.thumbnail_path, - ): + ) + if not settings.EMPTY_TRASH_DIR: + # Only delete the original file if we are not moving it to trash dir + files += (instance.source_path,) + + for filename in files: if filename and os.path.isfile(filename): try: os.unlink(filename)