From 9c8c1b8fa8cea90717a3ea4e4647be0a50a12e38 Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Tue, 30 Dec 2025 13:56:54 -0800
Subject: [PATCH] Sonar fixes

---
 .../share-link-bundle-dialog.component.html               | 1 +
 .../share-link-bundle-dialog.component.ts                 | 8 ++++----
 .../share-link-bundle-manage-dialog.component.ts          | 8 ++++----
 .../document-list/bulk-editor/bulk-editor.component.ts    | 4 ++--
 4 files changed, 11 insertions(+), 10 deletions(-)

diff --git a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html
index 0fa942a38..b7fed28e1 100644
--- a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html
+++ b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.html
@@ -42,6 +42,7 @@
             role="switch"
             id="shareArchiveSwitch"
             formControlName="shareArchiveVersion"
+            aria-checked="{{ shareArchiveVersion }}"
           />
           <label class="form-check-label" for="shareArchiveSwitch" i18n>Share archive version (if available)</label>
         </div>
diff --git a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts
index 0226cd8df..37aa70950 100644
--- a/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts
+++ b/src-ui/src/app/components/common/share-link-bundle-dialog/share-link-bundle-dialog.component.ts
@@ -34,16 +34,16 @@ import { ConfirmDialogComponent } from '../confirm-dialog/confirm-dialog.compone
   providers: [],
 })
 export class ShareLinkBundleDialogComponent extends ConfirmDialogComponent {
-  private formBuilder = inject(FormBuilder)
-  private clipboard = inject(Clipboard)
-  private toastService = inject(ToastService)
+  private readonly formBuilder = inject(FormBuilder)
+  private readonly clipboard = inject(Clipboard)
+  private readonly toastService = inject(ToastService)
 
   private _documents: Document[] = []
 
   selectionCount = 0
   documentPreview: Document[] = []
   form: FormGroup = this.formBuilder.group({
-    shareArchiveVersion: [true],
+    shareArchiveVersion: true,
     expirationDays: [7],
   })
   payload: ShareLinkBundleCreatePayload | null = null
diff --git a/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts b/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts
index bda01745b..fdc9f0126 100644
--- a/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts
+++ b/src-ui/src/app/components/common/share-link-bundle-manage-dialog/share-link-bundle-manage-dialog.component.ts
@@ -32,10 +32,10 @@ export class ShareLinkBundleManageDialogComponent
   extends LoadingComponentWithPermissions
   implements OnInit, OnDestroy
 {
-  private activeModal = inject(NgbActiveModal)
-  private shareLinkBundleService = inject(ShareLinkBundleService)
-  private toastService = inject(ToastService)
-  private clipboard = inject(Clipboard)
+  private readonly activeModal = inject(NgbActiveModal)
+  private readonly shareLinkBundleService = inject(ShareLinkBundleService)
+  private readonly toastService = inject(ToastService)
+  private readonly clipboard = inject(Clipboard)
 
   title = $localize`Share link bundles`
 
diff --git a/src-ui/src/app/components/document-list/bulk-editor/bulk-editor.component.ts b/src-ui/src/app/components/document-list/bulk-editor/bulk-editor.component.ts
index 69bba8141..0c58c7d84 100644
--- a/src-ui/src/app/components/document-list/bulk-editor/bulk-editor.component.ts
+++ b/src-ui/src/app/components/document-list/bulk-editor/bulk-editor.component.ts
@@ -90,7 +90,7 @@ export class BulkEditorComponent
   private customFieldService = inject(CustomFieldsService)
   private permissionService = inject(PermissionsService)
   private savedViewService = inject(SavedViewService)
-  private shareLinkBundleService = inject(ShareLinkBundleService)
+  private readonly shareLinkBundleService = inject(ShareLinkBundleService)
 
   tagSelectionModel = new FilterableDropdownSelectionModel(true)
   correspondentSelectionModel = new FilterableDropdownSelectionModel()
@@ -962,7 +962,7 @@ export class BulkEditorComponent
   }
 
   manageShareLinkBundles() {
-    const modal = this.modalService.open(ShareLinkBundleManageDialogComponent, {
+    this.modalService.open(ShareLinkBundleManageDialogComponent, {
       backdrop: 'static',
       size: 'lg',
     })