From a7e1c1c4d04c2d29d5dd3e55ef6d3e10a5b8bedd Mon Sep 17 00:00:00 2001 From: Felix Eckhofer Date: Sun, 20 Feb 2022 14:04:43 +0100 Subject: [PATCH] Catch exception during trash-move --- src/documents/signals/handlers.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/src/documents/signals/handlers.py b/src/documents/signals/handlers.py index a86ee047f..cf8b4fed2 100644 --- a/src/documents/signals/handlers.py +++ b/src/documents/signals/handlers.py @@ -247,7 +247,14 @@ def cleanup_document_deletion(sender, instance, using, **kwargs): logger.debug( f"Moving {instance.source_path} to trash at {new_file_path}") - os.rename(instance.source_path, new_file_path) + try: + os.rename(instance.source_path, new_file_path) + except OSError as e: + logger.error( + f"Failed to move {instance.source_path} to trash at " + f"{new_file_path}: {e}. Skipping cleanup!" + ) + return for filename in (instance.source_path, instance.archive_path,