From ac1b0efc199c72936bffbccee1baa059c898fdce Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Thu, 11 Sep 2025 21:39:33 -0700 Subject: [PATCH] Make codeQL happy --- src/documents/serialisers.py | 6 ++++-- src/documents/tests/test_tag_hierarchy.py | 2 +- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/documents/serialisers.py b/src/documents/serialisers.py index 83d250eaa..956da8129 100644 --- a/src/documents/serialisers.py +++ b/src/documents/serialisers.py @@ -591,7 +591,8 @@ class TagSerializer(MatchingModelSerializer, OwnedObjectSerializer): self.instance.parent = parent self.instance.clean() except ValidationError as e: - raise serializers.ValidationError({"parent": list(e)}) + logger.debug("Tag parent validation failed: %s", e) + raise serializers.ValidationError({"parent": _("Invalid parent tag.")}) finally: self.instance.parent = original_parent else: @@ -600,7 +601,8 @@ class TagSerializer(MatchingModelSerializer, OwnedObjectSerializer): try: temp.clean() except ValidationError as e: - raise serializers.ValidationError({"parent": list(e)}) + logger.debug("Tag parent validation failed: %s", e) + raise serializers.ValidationError({"parent": _("Invalid parent tag.")}) return super().validate(attrs) diff --git a/src/documents/tests/test_tag_hierarchy.py b/src/documents/tests/test_tag_hierarchy.py index 14ba3cce4..accf8f85b 100644 --- a/src/documents/tests/test_tag_hierarchy.py +++ b/src/documents/tests/test_tag_hierarchy.py @@ -161,7 +161,7 @@ class TestTagHierarchy(APITestCase): ) assert resp_fail.status_code == 400 assert "parent" in resp_fail.data - assert any("Maximum" in str(msg) for msg in resp_fail.data["parent"]) + assert "Invalid" in str(resp_fail.data["parent"]) def test_max_depth_on_move_subtree(self): a = Tag.objects.create(name="A2")