From aef68f0b415d8bdc65f9c1b5df7d21708a49575b Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Fri, 3 Jan 2025 19:04:02 -0800
Subject: [PATCH] Fix: fix saved views triggering changeafterchecked warning

---
 src-ui/messages.xlf                                         | 6 +++---
 .../manage/saved-views/saved-views.component.html           | 2 +-
 .../components/manage/saved-views/saved-views.component.ts  | 5 +++--
 3 files changed, 7 insertions(+), 6 deletions(-)

diff --git a/src-ui/messages.xlf b/src-ui/messages.xlf
index c22fdc535..4964096c7 100644
--- a/src-ui/messages.xlf
+++ b/src-ui/messages.xlf
@@ -8510,21 +8510,21 @@
         <source>Saved view &quot;<x id="PH" equiv-text="savedView.name"/>&quot; deleted.</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/manage/saved-views/saved-views.component.ts</context>
-          <context context-type="linenumber">132</context>
+          <context context-type="linenumber">133</context>
         </context-group>
       </trans-unit>
       <trans-unit id="1660419335376265526" datatype="html">
         <source>Views saved successfully.</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/manage/saved-views/saved-views.component.ts</context>
-          <context context-type="linenumber">157</context>
+          <context context-type="linenumber">158</context>
         </context-group>
       </trans-unit>
       <trans-unit id="1699877326523238632" datatype="html">
         <source>Error while saving views.</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/manage/saved-views/saved-views.component.ts</context>
-          <context context-type="linenumber">162</context>
+          <context context-type="linenumber">163</context>
         </context-group>
       </trans-unit>
       <trans-unit id="5101757640976222639" datatype="html">
diff --git a/src-ui/src/app/components/manage/saved-views/saved-views.component.html b/src-ui/src/app/components/manage/saved-views/saved-views.component.html
index 58111fa5e..296cf71ac 100644
--- a/src-ui/src/app/components/manage/saved-views/saved-views.component.html
+++ b/src-ui/src/app/components/manage/saved-views/saved-views.component.html
@@ -62,7 +62,7 @@
       </li>
     }
 
-    @if (!savedViews) {
+    @if (loading) {
       <li class="list-group-item">
         <div class="spinner-border spinner-border-sm fw-normal ms-2 me-auto" role="status"></div>
         <div class="visually-hidden" i18n>Loading...</div>
diff --git a/src-ui/src/app/components/manage/saved-views/saved-views.component.ts b/src-ui/src/app/components/manage/saved-views/saved-views.component.ts
index c9ccf9355..ee2b00c2b 100644
--- a/src-ui/src/app/components/manage/saved-views/saved-views.component.ts
+++ b/src-ui/src/app/components/manage/saved-views/saved-views.component.ts
@@ -61,11 +61,11 @@ export class SavedViewsComponent
     private toastService: ToastService
   ) {
     super()
+    this.settings.organizingSidebarSavedViews = true
   }
 
   ngOnInit(): void {
-    this.settings.organizingSidebarSavedViews = true
-
+    this.loading = true
     this.savedViewService.listAll().subscribe((r) => {
       this.savedViews = r.results
       this.initialize()
@@ -78,6 +78,7 @@ export class SavedViewsComponent
   }
 
   private initialize() {
+    this.loading = false
     this.emptyGroup(this.savedViewsGroup)
 
     let storeData = {