Fix: Crash in barcode ASN reading when the file type isn't supported (#5261)

* Fixes a random crash in the barcode ASN reading so it doesn't try to access a not created temp dir

* Don't parse the barcodes twice, store the result instead
This commit is contained in:
Trenton H
2024-01-05 21:08:24 -08:00
committed by GitHub
parent a82e3771ae
commit bd35030c59
2 changed files with 9 additions and 3 deletions

View File

@@ -152,10 +152,13 @@ def consume_file(
return "File successfully split"
# try reading the ASN from barcode
if settings.CONSUMER_ENABLE_ASN_BARCODE and reader.asn is not None:
if (
settings.CONSUMER_ENABLE_ASN_BARCODE
and (located_asn := reader.asn) is not None
):
# Note this will take precedence over an API provided ASN
# But it's from a physical barcode, so that's good
overrides.asn = reader.asn
overrides.asn = located_asn
logger.info(f"Found ASN in barcode: {overrides.asn}")
template_overrides = Consumer().get_workflow_overrides(