Fix: saved view permissions fixes (#7672)

src-ui/src/app/components/admin/settings/settings.component.html

@@ -332,7 +332,7 @@
       </ng-template>
     </li>
 
-    <li [ngbNavItem]="SettingsNavIDs.SavedViews">
+    <li [ngbNavItem]="SettingsNavIDs.SavedViews" *pngxIfPermissions="{ action: PermissionAction.Change, type: PermissionType.SavedView }">
       <a ngbNavLink i18n>Saved views</a>
       <ng-template ngbNavContent>
 

src-ui/src/app/components/app-frame/app-frame.component.spec.ts

@@ -115,7 +115,7 @@ describe('AppFrameComponent', () => {
         {
           provide: SavedViewService,
           useValue: {
-            initialize: () => {},
+            reload: () => {},
             listAll: () =>
               of({
                 all: [saved_views.map((v) => v.id)],
@@ -170,7 +170,7 @@ describe('AppFrameComponent', () => {
       .mockReturnValue('Hello World')
     jest.spyOn(permissionsService, 'currentUserCan').mockReturnValue(true)
 
-    savedViewSpy = jest.spyOn(savedViewService, 'initialize')
+    savedViewSpy = jest.spyOn(savedViewService, 'reload')
 
     fixture = TestBed.createComponent(AppFrameComponent)
     component = fixture.componentInstance

src-ui/src/app/components/app-frame/app-frame.component.ts

@@ -73,7 +73,7 @@ export class AppFrameComponent
         PermissionType.SavedView
       )
     ) {
-      this.savedViewService.initialize()
+      this.savedViewService.reload()
     }
   }
 

src-ui/src/app/services/rest/saved-view.service.spec.ts

@@ -57,7 +57,7 @@ describe(`Additional service tests for SavedViewService`, () => {
   let settingsService
 
   it('should retrieve saved views and sort them', () => {
-    service.initialize()
+    service.reload()
     const req = httpTestingController.expectOne(
       `${environment.apiBaseUrl}${endpoint}/?page=1&page_size=100000`
     )
@@ -70,7 +70,7 @@ describe(`Additional service tests for SavedViewService`, () => {
   })
 
   it('should gracefully handle errors', () => {
-    service.initialize()
+    service.reload()
     const req = httpTestingController.expectOne(
       `${environment.apiBaseUrl}${endpoint}/?page=1&page_size=100000`
     )

src-ui/src/app/services/rest/saved-view.service.ts

@@ -6,6 +6,7 @@ import { SavedView } from 'src/app/data/saved-view'
 import { AbstractPaperlessService } from './abstract-paperless-service'
 import { SettingsService } from '../settings.service'
 import { SETTINGS_KEYS } from 'src/app/data/ui-settings'
+import { Results } from 'src/app/data/results'
 
 @Injectable({
   providedIn: 'root',
@@ -21,22 +22,31 @@ export class SavedViewService extends AbstractPaperlessService<SavedView> {
     super(http, 'saved_views')
   }
 
-  public initialize() {
-    this.reload()
-  }
-
-  private reload() {
-    this.listAll().subscribe({
+  public list(
+    page?: number,
+    pageSize?: number,
+    sortField?: string,
+    sortReverse?: boolean,
+    extraParams?: any
+  ): Observable<Results<SavedView>> {
+    return super.list(page, pageSize, sortField, sortReverse, extraParams).pipe(
+      tap({
         next: (r) => {
           this.savedViews = r.results
           this.loading = false
-        this.settingsService.dashboardIsEmpty = this.dashboardViews.length === 0
+          this.settingsService.dashboardIsEmpty =
+            this.dashboardViews.length === 0
         },
         error: () => {
           this.loading = false
           this.settingsService.dashboardIsEmpty = true
         },
       })
+    )
+  }
+
+  public reload() {
+    this.listAll().subscribe()
   }
 
   get allViews() {