From c2b4787c45a37fbe5ee6cad30c71744bbf1053a9 Mon Sep 17 00:00:00 2001
From: shamoon <4887959+shamoon@users.noreply.github.com>
Date: Tue, 10 Feb 2026 23:45:07 -0800
Subject: [PATCH] Sonar

---
 .../components/document-detail/document-detail.component.ts   | 4 ++--
 src/documents/conditionals.py                                 | 4 ----
 2 files changed, 2 insertions(+), 6 deletions(-)

diff --git a/src-ui/src/app/components/document-detail/document-detail.component.ts b/src-ui/src/app/components/document-detail/document-detail.component.ts
index c9a518536..c8350a98f 100644
--- a/src-ui/src/app/components/document-detail/document-detail.component.ts
+++ b/src-ui/src/app/components/document-detail/document-detail.component.ts
@@ -215,7 +215,7 @@ export class DocumentDetailComponent
   private componentRouterService = inject(ComponentRouterService)
   private deviceDetectorService = inject(DeviceDetectorService)
   private savedViewService = inject(SavedViewService)
-  private websocketStatusService = inject(WebsocketStatusService)
+  private readonly websocketStatusService = inject(WebsocketStatusService)
 
   @ViewChild('inputTitle')
   titleInput: TextComponent
@@ -1320,7 +1320,7 @@ export class DocumentDetailComponent
           ).pipe(take(1))
         }),
         switchMap((result) => {
-          if (!result || result.state !== 'success') {
+          if (result?.state !== 'success') {
             if (result?.state === 'failed') {
               this.versionUploadState = UploadState.Failed
               this.versionUploadError =
diff --git a/src/documents/conditionals.py b/src/documents/conditionals.py
index c1160d563..1768525fc 100644
--- a/src/documents/conditionals.py
+++ b/src/documents/conditionals.py
@@ -129,7 +129,6 @@ def metadata_etag(request, pk: int) -> str | None:
     if doc is None:
         return None
     return doc.checksum
-    return None
 
 
 def metadata_last_modified(request, pk: int) -> datetime | None:
@@ -142,7 +141,6 @@ def metadata_last_modified(request, pk: int) -> datetime | None:
     if doc is None:
         return None
     return doc.modified
-    return None
 
 
 def preview_etag(request, pk: int) -> str | None:
@@ -158,7 +156,6 @@ def preview_etag(request, pk: int) -> str | None:
         and request.query_params["original"] == "true"
     )
     return doc.checksum if use_original else doc.archive_checksum
-    return None
 
 
 def preview_last_modified(request, pk: int) -> datetime | None:
@@ -170,7 +167,6 @@ def preview_last_modified(request, pk: int) -> datetime | None:
     if doc is None:
         return None
     return doc.modified
-    return None
 
 
 def thumbnail_last_modified(request: Any, pk: int) -> datetime | None: