fix code style issues

solve merge conflicts

format code

format code

format code
This commit is contained in:
Frank Strieter 2022-03-23 08:33:19 +01:00
parent a27fb173dd
commit ccee85a05e
8 changed files with 222 additions and 225 deletions

View File

@ -8,9 +8,6 @@ on:
types: types:
- opened - opened
- reopened - reopened
branches:
- main
- dev
# map fields with customized labels # map fields with customized labels
env: env:

View File

@ -51,8 +51,7 @@
"src/favicon.ico", "src/favicon.ico",
"src/apple-touch-icon.png", "src/apple-touch-icon.png",
"src/assets", "src/assets",
"src/manifest.webmanifest", "src/manifest.webmanifest", {
{
"glob": "pdf.worker.min.js", "glob": "pdf.worker.min.js",
"input": "node_modules/pdfjs-dist/build/", "input": "node_modules/pdfjs-dist/build/",
"output": "/assets/js/" "output": "/assets/js/"
@ -102,9 +101,7 @@
] ]
}, },
"en-US": { "en-US": {
"localize": [ "localize": ["en-US"]
"en-US"
]
} }
}, },
"defaultConfiguration": "" "defaultConfiguration": ""

View File

@ -1,8 +1,8 @@
module.exports = { module.exports = {
moduleNameMapper: { moduleNameMapper: {
"@core/(.*)": "<rootDir>/src/app/core/$1", '@core/(.*)': '<rootDir>/src/app/core/$1',
}, },
preset: "jest-preset-angular", preset: 'jest-preset-angular',
setupFilesAfterEnv: ["<rootDir>/setup-jest.ts"], setupFilesAfterEnv: ['<rootDir>/setup-jest.ts'],
testPathIgnorePatterns: ["/node_modules/", "/cypress/"], testPathIgnorePatterns: ['/node_modules/', '/cypress/'],
}; }

View File

@ -9,7 +9,7 @@
"lint": "ng lint", "lint": "ng lint",
"e2e": "ng e2e", "e2e": "ng e2e",
"cy:run": "cypress run", "cy:run": "cypress run",
"e2e:ci": "concurrently \"npm run start\" \"wait-on http-get://localhost:4200 && npm run cy:run\" --kill-others --success first" "e2e:ci": "concurrently 'npm run start' 'wait-on http-get://localhost:4200 && npm run cy:run' --kill-others --success first"
}, },
"private": true, "private": true,
"dependencies": { "dependencies": {

View File

@ -1,30 +1,30 @@
import 'jest-preset-angular/setup-jest'; import 'jest-preset-angular/setup-jest'
/* global mocks for jsdom */ /* global mocks for jsdom */
const mock = () => { const mock = () => {
let storage: { [key: string]: string } = {}; let storage: { [key: string]: string } = {}
return { return {
getItem: (key: string) => (key in storage ? storage[key] : null), getItem: (key: string) => (key in storage ? storage[key] : null),
setItem: (key: string, value: string) => (storage[key] = value || ''), setItem: (key: string, value: string) => (storage[key] = value || ''),
removeItem: (key: string) => delete storage[key], removeItem: (key: string) => delete storage[key],
clear: () => (storage = {}), clear: () => (storage = {}),
}; }
}; }
Object.defineProperty(window, 'localStorage', { value: mock() }); Object.defineProperty(window, 'localStorage', { value: mock() })
Object.defineProperty(window, 'sessionStorage', { value: mock() }); Object.defineProperty(window, 'sessionStorage', { value: mock() })
Object.defineProperty(window, 'getComputedStyle', { Object.defineProperty(window, 'getComputedStyle', {
value: () => ['-webkit-appearance'], value: () => ['-webkit-appearance'],
}); })
Object.defineProperty(document.body.style, 'transform', { Object.defineProperty(document.body.style, 'transform', {
value: () => { value: () => {
return { return {
enumerable: true, enumerable: true,
configurable: true, configurable: true,
}; }
}, },
}); })
/* output shorter and more meaningful Zone error stack traces */ /* output shorter and more meaningful Zone error stack traces */
// Error.stackTraceLimit = 2; // Error.stackTraceLimit = 2

View File

@ -19,27 +19,27 @@ export abstract class EditDialogComponent<T extends ObjectWithId>
) {} ) {}
@Input() @Input()
dialogMode: string = 'create'; dialogMode: string = 'create'
@Input() @Input()
object: T; object: T
@Output() @Output()
success = new EventEmitter(); success = new EventEmitter()
networkActive = false; networkActive = false
closeEnabled = false; closeEnabled = false
error = null; error = null
abstract getForm(): FormGroup; abstract getForm(): FormGroup
objectForm: FormGroup = this.getForm(); objectForm: FormGroup = this.getForm()
ngOnInit(): void { ngOnInit(): void {
if (this.object != null) { if (this.object != null) {
this.objectForm.patchValue(this.object); this.objectForm.patchValue(this.object)
} }
// wait to enable close button so it doesnt steal focus from input since its the first clickable element in the DOM // wait to enable close button so it doesnt steal focus from input since its the first clickable element in the DOM
@ -49,34 +49,34 @@ export abstract class EditDialogComponent<T extends ObjectWithId>
} }
getCreateTitle() { getCreateTitle() {
return $localize`Create new item`; return $localize`Create new item`
} }
getEditTitle() { getEditTitle() {
return $localize`Edit item`; return $localize`Edit item`
} }
getSaveErrorMessage(error: string) { getSaveErrorMessage(error: string) {
return $localize`Could not save element: ${error}`; return $localize`Could not save element: ${error}`
} }
getTitle() { getTitle() {
switch (this.dialogMode) { switch (this.dialogMode) {
case 'create': case 'create':
return this.getCreateTitle(); return this.getCreateTitle()
case 'edit': case 'edit':
return this.getEditTitle(); return this.getEditTitle()
default: default:
break break
} }
} }
getMatchingAlgorithms() { getMatchingAlgorithms() {
return MATCHING_ALGORITHMS; return MATCHING_ALGORITHMS
} }
get patternRequired(): boolean { get patternRequired(): boolean {
return this.objectForm?.value.matching_algorithm !== MATCH_AUTO; return this.objectForm?.value.matching_algorithm !== MATCH_AUTO
} }
save() { save() {
@ -90,7 +90,7 @@ export abstract class EditDialogComponent<T extends ObjectWithId>
serverResponse = this.service.create(newObject) serverResponse = this.service.create(newObject)
break break
case 'edit': case 'edit':
serverResponse = this.service.update(newObject); serverResponse = this.service.update(newObject)
default: default:
break break
} }
@ -108,6 +108,6 @@ export abstract class EditDialogComponent<T extends ObjectWithId>
} }
cancel() { cancel() {
this.activeModal.close(); this.activeModal.close()
} }
} }

View File

@ -17,6 +17,6 @@ import { AbstractInputComponent } from '../abstract-input'
}) })
export class CheckComponent extends AbstractInputComponent<boolean> { export class CheckComponent extends AbstractInputComponent<boolean> {
constructor() { constructor() {
super(); super()
} }
} }

View File

@ -1,21 +1,24 @@
import { TestBed } from '@angular/core/testing'; import { TestBed } from '@angular/core/testing'
type CompilerOptions = Partial<{ type CompilerOptions = Partial<{
providers: any[]; providers: any[]
useJit: boolean; useJit: boolean
preserveWhitespaces: boolean; preserveWhitespaces: boolean
}>; }>
export type ConfigureFn = (testBed: typeof TestBed) => void; export type ConfigureFn = (testBed: typeof TestBed) => void
export const configureTests = (configure: ConfigureFn, compilerOptions: CompilerOptions = {}) => { export const configureTests = (
configure: ConfigureFn,
compilerOptions: CompilerOptions = {}
) => {
const compilerConfig: CompilerOptions = { const compilerConfig: CompilerOptions = {
preserveWhitespaces: false, preserveWhitespaces: false,
...compilerOptions, ...compilerOptions,
}; }
const configuredTestBed = TestBed.configureCompiler(compilerConfig); const configuredTestBed = TestBed.configureCompiler(compilerConfig)
configure(configuredTestBed); configure(configuredTestBed)
return configuredTestBed.compileComponents().then(() => configuredTestBed); return configuredTestBed.compileComponents().then(() => configuredTestBed)
}; }