Configures ruff as the one stop linter and resolves warnings it raised

src/documents/management/commands/document_consumer.py

@@ -159,7 +159,7 @@ def _consume_wait_unmodified(file: str) -> None:
             new_size = stat_data.st_size
         except FileNotFoundError:
             logger.debug(
-                f"File {file} moved while waiting for it to remain " f"unmodified.",
+                f"File {file} moved while waiting for it to remain unmodified.",
             )
             return
         if new_mtime == mtime and new_size == size:
@@ -293,10 +293,7 @@ class Command(BaseCommand):
         while not finished:
             try:
                 for event in inotify.read(timeout=timeout):
-                    if recursive:
-                        path = inotify.get_path(event.wd)
-                    else:
-                        path = directory
+                    path = inotify.get_path(event.wd) if recursive else directory
                     filepath = os.path.join(path, event.name)
                     notified_files[filepath] = monotonic()
 

src/documents/management/commands/document_create_classifier.py

@@ -1,6 +1,6 @@
 from django.core.management.base import BaseCommand
 
-from ...tasks import train_classifier
+from documents.tasks import train_classifier
 
 
 class Command(BaseCommand):

src/documents/management/commands/document_exporter.py

@@ -35,8 +35,8 @@ from paperless.db import GnuPG
 from paperless_mail.models import MailAccount
 from paperless_mail.models import MailRule
 
-from ...file_handling import delete_empty_directories
-from ...file_handling import generate_filename
+from documents.file_handling import delete_empty_directories
+from documents.file_handling import generate_filename
 
 
 class Command(BaseCommand):
@@ -403,9 +403,10 @@ class Command(BaseCommand):
             if self.compare_checksums and source_checksum:
                 target_checksum = hashlib.md5(target.read_bytes()).hexdigest()
                 perform_copy = target_checksum != source_checksum
-            elif source_stat.st_mtime != target_stat.st_mtime:
-                perform_copy = True
-            elif source_stat.st_size != target_stat.st_size:
+            elif (
+                source_stat.st_mtime != target_stat.st_mtime
+                or source_stat.st_size != target_stat.st_size
+            ):
                 perform_copy = True
         else:
             # Copy if it does not exist

src/documents/management/commands/document_importer.py

@@ -22,8 +22,8 @@ from documents.settings import EXPORTER_THUMBNAIL_NAME
 from filelock import FileLock
 from paperless import version
 
-from ...file_handling import create_source_path_directory
-from ...signals.handlers import update_filename_and_move_files
+from documents.file_handling import create_source_path_directory
+from documents.signals.handlers import update_filename_and_move_files
 
 
 @contextmanager
@@ -111,37 +111,36 @@ class Command(BaseCommand):
             post_save,
             receiver=update_filename_and_move_files,
             sender=Document,
+        ), disable_signal(
+            m2m_changed,
+            receiver=update_filename_and_move_files,
+            sender=Document.tags.through,
         ):
-            with disable_signal(
-                m2m_changed,
-                receiver=update_filename_and_move_files,
-                sender=Document.tags.through,
-            ):
-                # Fill up the database with whatever is in the manifest
-                try:
-                    for manifest_path in manifest_paths:
-                        call_command("loaddata", manifest_path)
-                except (FieldDoesNotExist, DeserializationError) as e:
-                    self.stdout.write(self.style.ERROR("Database import failed"))
-                    if (
-                        self.version is not None
-                        and self.version != version.__full_version_str__
-                    ):
-                        self.stdout.write(
-                            self.style.ERROR(
-                                "Version mismatch: "
-                                f"Currently {version.__full_version_str__},"
-                                f" importing {self.version}",
-                            ),
-                        )
-                        raise e
-                    else:
-                        self.stdout.write(
-                            self.style.ERROR("No version information present"),
-                        )
-                        raise e
+            # Fill up the database with whatever is in the manifest
+            try:
+                for manifest_path in manifest_paths:
+                    call_command("loaddata", manifest_path)
+            except (FieldDoesNotExist, DeserializationError) as e:
+                self.stdout.write(self.style.ERROR("Database import failed"))
+                if (
+                    self.version is not None
+                    and self.version != version.__full_version_str__
+                ):
+                    self.stdout.write(
+                        self.style.ERROR(
+                            "Version mismatch: "
+                            f"Currently {version.__full_version_str__},"
+                            f" importing {self.version}",
+                        ),
+                    )
+                    raise e
+                else:
+                    self.stdout.write(
+                        self.style.ERROR("No version information present"),
+                    )
+                    raise e
 
-                self._import_files_from_manifest(options["no_progress_bar"])
+            self._import_files_from_manifest(options["no_progress_bar"])
 
         self.stdout.write("Updating search index...")
         call_command(
@@ -154,14 +153,14 @@ class Command(BaseCommand):
     def _check_manifest_exists(path):
         if not os.path.exists(path):
             raise CommandError(
-                "That directory doesn't appear to contain a manifest.json " "file.",
+                "That directory doesn't appear to contain a manifest.json file.",
             )
 
     def _check_manifest(self):
 
         for record in self.manifest:
 
-            if not record["model"] == "documents.document":
+            if record["model"] != "documents.document":
                 continue
 
             if EXPORTER_FILE_NAME not in record:

src/documents/management/commands/document_retagger.py

@@ -5,10 +5,10 @@ from django.core.management.base import BaseCommand
 from documents.classifier import load_classifier
 from documents.models import Document
 
-from ...signals.handlers import set_correspondent
-from ...signals.handlers import set_document_type
-from ...signals.handlers import set_storage_path
-from ...signals.handlers import set_tags
+from documents.signals.handlers import set_correspondent
+from documents.signals.handlers import set_document_type
+from documents.signals.handlers import set_storage_path
+from documents.signals.handlers import set_tags
 
 
 logger = logging.getLogger("paperless.management.retagger")

src/documents/management/commands/document_thumbnails.py

@@ -7,7 +7,7 @@ from django import db
 from django.core.management.base import BaseCommand
 from documents.models import Document
 
-from ...parsers import get_parser_class_for_mime_type
+from documents.parsers import get_parser_class_for_mime_type
 
 
 def _process_document(doc_in):