Refactoring a few frontend components

This commit is contained in:
shamoon
2023-05-11 12:49:33 -07:00
parent 09086e574d
commit e293d23ae3
3 changed files with 11 additions and 9 deletions

View File

@@ -8,6 +8,7 @@ import {
} from 'src/app/services/permissions.service'
import { UserService } from 'src/app/services/rest/user.service'
import { SettingsService } from 'src/app/services/settings.service'
import { ComponentWithPermissions } from '../../with-permissions/with-permissions.component'
export class PermissionsSelectionModel {
ownerFilter: OwnerFilterType
@@ -38,9 +39,7 @@ export enum OwnerFilterType {
templateUrl: './permissions-filter-dropdown.component.html',
styleUrls: ['./permissions-filter-dropdown.component.scss'],
})
export class PermissionsFilterDropdownComponent {
public PermissionAction = PermissionAction
public PermissionType = PermissionType
export class PermissionsFilterDropdownComponent extends ComponentWithPermissions {
public OwnerFilterType = OwnerFilterType
@Input()
@@ -71,6 +70,7 @@ export class PermissionsFilterDropdownComponent {
userService: UserService,
private settingsService: SettingsService
) {
super()
if (
permissionsService.currentUserCan(
PermissionAction.View,

View File

@@ -11,6 +11,7 @@ import {
PermissionsService,
PermissionType,
} from 'src/app/services/permissions.service'
import { ComponentWithPermissions } from '../../with-permissions/with-permissions.component'
@Component({
providers: [
@@ -25,11 +26,9 @@ import {
styleUrls: ['./permissions-select.component.scss'],
})
export class PermissionsSelectComponent
extends ComponentWithPermissions
implements OnInit, ControlValueAccessor
{
PermissionType = PermissionType
PermissionAction = PermissionAction
@Input()
title: string = 'Permissions'
@@ -62,6 +61,7 @@ export class PermissionsSelectComponent
inheritedWarning: string = $localize`Inherited from group`
constructor(private readonly permissionsService: PermissionsService) {
super()
for (const type in PermissionType) {
const control = new FormGroup({})
for (const action in PermissionAction) {