From ea18fb611f65183f225d3feb3154a60fce06ae88 Mon Sep 17 00:00:00 2001 From: shamoon <4887959+shamoon@users.noreply.github.com> Date: Tue, 29 Jul 2025 23:31:18 -0400 Subject: [PATCH] Move update length check before operations --- src/documents/bulk_edit.py | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/documents/bulk_edit.py b/src/documents/bulk_edit.py index 894d0d4aa..af6be45b6 100644 --- a/src/documents/bulk_edit.py +++ b/src/documents/bulk_edit.py @@ -528,6 +528,12 @@ def edit_pdf( max_idx = max(op.get("doc", 0) for op in operations) pdf_docs = [pikepdf.new() for _ in range(max_idx + 1)] + if update_document and len(pdf_docs) > 1: + logger.error( + "Update requested but multiple output documents specified", + ) + return "ERROR" + for op in operations: dst = pdf_docs[op.get("doc", 0)] page = src.pages[op["page"] - 1] @@ -536,11 +542,6 @@ def edit_pdf( dst.pages[-1].rotate(op["rotate"], relative=True) if update_document: - if len(pdf_docs) != 1: - logger.error( - "Update requested but multiple output documents specified", - ) - return "ERROR" pdf = pdf_docs[0] pdf.remove_unreferenced_resources() pdf.save(doc.source_path)