From ef924e896b8b7740d166b4d0d27525a74e93b664 Mon Sep 17 00:00:00 2001 From: Michael Shamoon <4887959+nikonratm@users.noreply.github.com> Date: Fri, 15 Jan 2021 07:57:01 -0800 Subject: [PATCH] Fix reverting old selection in all cases by always doing it --- src-ui/src/app/services/document-list-view.service.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src-ui/src/app/services/document-list-view.service.ts b/src-ui/src/app/services/document-list-view.service.ts index 1fc5e09c5..4eb0c276c 100644 --- a/src-ui/src/app/services/document-list-view.service.ts +++ b/src-ui/src/app/services/document-list-view.service.ts @@ -266,10 +266,8 @@ export class DocumentListViewService { const fromIndex = Math.min(this.rangeSelectionAnchorIndex, documentToIndex) const toIndex = Math.max(this.rangeSelectionAnchorIndex, documentToIndex) - if (this.lastRangeSelectionToIndex !== null && - ((this.lastRangeSelectionToIndex > this.rangeSelectionAnchorIndex && documentToIndex <= this.rangeSelectionAnchorIndex) || - (this.lastRangeSelectionToIndex < this.rangeSelectionAnchorIndex && documentToIndex >= this.rangeSelectionAnchorIndex))) { - // new click is "opposite side" of anchor so we invert the old selection + if (this.lastRangeSelectionToIndex !== null) { + // revert the old selection this.documents.slice(Math.min(this.rangeSelectionAnchorIndex, this.lastRangeSelectionToIndex), Math.max(this.rangeSelectionAnchorIndex, this.lastRangeSelectionToIndex) + 1).forEach(d => { this.selected.delete(d.id) })