paradizelost/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2025-04-02 13:45:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix: Always clean up INotify (#9359)

Browse Source
This commit is contained in:
Trenton H 2025-03-11 10:01:00 -07:00 committed by GitHub
parent 169aa8c8bd
commit f4413e0a08
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 50 additions and 50 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

100
src/documents/management/commands/document_consumer.py
View File

@ -294,9 +294,9 @@ class Command(BaseCommand):
inotify = INotify() inotify = INotify()
inotify_flags = flags.CLOSE_WRITE | flags.MOVED_TO | flags.MODIFY inotify_flags = flags.CLOSE_WRITE | flags.MOVED_TO | flags.MODIFY
if recursive: if recursive:
descriptor = inotify.add_watch_recursive(directory, inotify_flags) inotify.add_watch_recursive(directory, inotify_flags)
else: else:
descriptor = inotify.add_watch(directory, inotify_flags) inotify.add_watch(directory, inotify_flags)
inotify_debounce_secs: Final[float] = settings.CONSUMER_INOTIFY_DELAY inotify_debounce_secs: Final[float] = settings.CONSUMER_INOTIFY_DELAY
inotify_debounce_ms: Final[int] = inotify_debounce_secs * 1000 inotify_debounce_ms: Final[int] = inotify_debounce_secs * 1000
@ -305,55 +305,55 @@ class Command(BaseCommand):
notified_files = {} notified_files = {}
while not finished: try:
try: while not finished:
for event in inotify.read(timeout=timeout_ms): try:
path = inotify.get_path(event.wd) if recursive else directory for event in inotify.read(timeout=timeout_ms):
filepath = os.path.join(path, event.name) path = inotify.get_path(event.wd) if recursive else directory
if flags.MODIFY in flags.from_mask(event.mask): filepath = os.path.join(path, event.name)
notified_files.pop(filepath, None) if flags.MODIFY in flags.from_mask(event.mask):
notified_files.pop(filepath, None)
else:
notified_files[filepath] = monotonic()
# Check the files against the timeout
still_waiting = {}
# last_event_time is time of the last inotify event for this file
for filepath, last_event_time in notified_files.items():
# Current time - last time over the configured timeout
waited_long_enough = (
monotonic() - last_event_time
) > inotify_debounce_secs
# Also make sure the file exists still, some scanners might write a
# temporary file first
file_still_exists = os.path.exists(filepath) and os.path.isfile(
filepath,
)
if waited_long_enough and file_still_exists:
_consume(filepath)
elif file_still_exists:
still_waiting[filepath] = last_event_time
# These files are still waiting to hit the timeout
notified_files = still_waiting
# If files are waiting, need to exit read() to check them
# Otherwise, go back to infinite sleep time, but only if not testing
if len(notified_files) > 0:
timeout_ms = inotify_debounce_ms
elif is_testing:
timeout_ms = self.testing_timeout_ms
else: else:
notified_files[filepath] = monotonic() timeout_ms = None
# Check the files against the timeout if self.stop_flag.is_set():
still_waiting = {} logger.debug("Finishing because event is set")
# last_event_time is time of the last inotify event for this file finished = True
for filepath, last_event_time in notified_files.items():
# Current time - last time over the configured timeout
waited_long_enough = (
monotonic() - last_event_time
) > inotify_debounce_secs
# Also make sure the file exists still, some scanners might write a except KeyboardInterrupt:
# temporary file first logger.info("Received SIGINT, stopping inotify")
file_still_exists = os.path.exists(filepath) and os.path.isfile(
filepath,
)
if waited_long_enough and file_still_exists:
_consume(filepath)
elif file_still_exists:
still_waiting[filepath] = last_event_time
# These files are still waiting to hit the timeout
notified_files = still_waiting
# If files are waiting, need to exit read() to check them
# Otherwise, go back to infinite sleep time, but only if not testing
if len(notified_files) > 0:
timeout_ms = inotify_debounce_ms
elif is_testing:
timeout_ms = self.testing_timeout_ms
else:
timeout_ms = None
if self.stop_flag.is_set():
logger.debug("Finishing because event is set")
finished = True finished = True
finally:
except KeyboardInterrupt: inotify.close()
logger.info("Received SIGINT, stopping inotify")
finished = True
inotify.rm_watch(descriptor)
inotify.close()