From fdaf9e9b46ea2b660a71484dfc3de532225220bf Mon Sep 17 00:00:00 2001
From: Michael Shamoon <4887959+shamoon@users.noreply.github.com>
Date: Sun, 13 Nov 2022 14:18:44 -0800
Subject: [PATCH] Revert "fix: update user permissions and groups, update group
 permissions"

This reverts commit 57b709824fa058a41c3f13066b27f83ca1281b2c.
---
 src/paperless/serialisers.py | 70 +++++++++++++++---------------------
 1 file changed, 29 insertions(+), 41 deletions(-)

diff --git a/src/paperless/serialisers.py b/src/paperless/serialisers.py
index 44f4a3653..af0dbe8ad 100644
--- a/src/paperless/serialisers.py
+++ b/src/paperless/serialisers.py
@@ -1,11 +1,12 @@
 from django.contrib.auth.models import Group
-from django.contrib.auth.models import Permission
 from django.contrib.auth.models import User
 from rest_framework import serializers
 
 
 class UserSerializer(serializers.ModelSerializer):
 
+    groups = serializers.SerializerMethodField()
+    permissions = serializers.SerializerMethodField()
     inherited_permissions = serializers.SerializerMethodField()
 
     class Meta:
@@ -15,28 +16,36 @@ class UserSerializer(serializers.ModelSerializer):
             "username",
             "first_name",
             "last_name",
-            "email",
             "date_joined",
-            "last_login",
-            "is_active",
             "is_staff",
+            "is_active",
             "is_superuser",
             "groups",
-            "user_permissions",
+            "permissions",
             "inherited_permissions",
         )
 
-    def get_inherited_permissions(self, obj):
-        inherited_permissions_ids = []
-        inherited_permissions = obj.get_group_permissions()
-        for permission in inherited_permissions:
-            inherited_permissions_ids.append(
-                perm_to_permission(permission).pk,
+    def get_groups(self, obj):
+        return list(obj.groups.values_list("name", flat=True))
+
+    def get_permissions(self, obj):
+        # obj.get_user_permissions() returns more permissions than desired
+        permission_natural_keys = []
+        permissions = obj.user_permissions.all()
+        for permission in permissions:
+            permission_natural_keys.append(
+                permission.natural_key()[1] + "." + permission.natural_key()[0],
             )
-        return list(set(inherited_permissions_ids))
+        return permission_natural_keys
+
+    def get_inherited_permissions(self, obj):
+        return obj.get_group_permissions()
 
 
 class GroupSerializer(serializers.ModelSerializer):
+
+    permissions = serializers.SerializerMethodField()
+
     class Meta:
         model = Group
         fields = (
@@ -45,32 +54,11 @@ class GroupSerializer(serializers.ModelSerializer):
             "permissions",
         )
 
-
-def perm_to_permission(perm):
-
-    """
-    Convert a identifier string permission format in 'app_label.codename'
-    (teremd as *perm*) to a django permission instance.
-
-    Examples
-    --------
-    >>> permission = perm_to_permission('auth.add_user')
-    >>> permission.content_type.app_label == 'auth'
-    True
-    >>> permission.codename == 'add_user'
-    True
-    """
-
-    try:
-        app_label, codename = perm.split(".", 1)
-    except IndexError:
-        raise AttributeError(
-            "The format of identifier string permission (perm) is wrong. "
-            "It should be in 'app_label.codename'.",
-        )
-    else:
-        permission = Permission.objects.get(
-            content_type__app_label=app_label,
-            codename=codename,
-        )
-        return permission
+    def get_permissions(self, obj):
+        permission_natural_keys = []
+        permissions = obj.permissions.all()
+        for permission in permissions:
+            permission_natural_keys.append(
+                permission.natural_key()[1] + "." + permission.natural_key()[0],
+            )
+        return permission_natural_keys