Fix the current handling

src/documents/consumer.py

@@ -468,7 +468,7 @@ class ConsumerPlugin(
         # now that everything is done, we can start to store the document
         # in the system. This will be a transaction and reasonably fast.
         success = False
-        store_exception = None
+        result = None
         try:
             with transaction.atomic():
                 # store the document.
@@ -535,8 +535,18 @@ class ConsumerPlugin(
                 document.save()
                 success = True
 
-        except Exception as fail_exc:
+        except Exception as e:
-            store_exception = fail_exc
+            # save the exception for later
+            try:
+                self._fail(
+                    str(e),
+                    f"The following error occurred while storing document "
+                    f"{self.filename} after parsing: {e}",
+                    exc_info=True,
+                    exception=e,
+                )
+            except Exception as fail_exc:
+                stored_exception = fail_exc
         finally:
             if success:
                 # Delete the file only if it was successfully consumed
@@ -571,25 +581,18 @@ class ConsumerPlugin(
                 # Return the most up to date fields
                 document.refresh_from_db()
 
-                document_parser.cleanup()
+                result = f"Success. New document id {document.pk} created"
-                tempdir.cleanup()
+            elif stored_exception:
-                return f"Success. New document id {document.pk} created"
+                raise stored_exception
             else:
-                document_parser.cleanup()
+                self._fail(
-                tempdir.cleanup()
+                    ConsumerStatusShortMessage.FAILED,
-                if store_exception:
+                    f"Error occurred while saving {self.filename}.",
-                    self._fail(
+                )
-                        str(store_exception),
+
-                        f"The following error occurred while storing document "
+            document_parser.cleanup()
-                        f"{self.filename} after parsing: {store_exception}",
+            tempdir.cleanup()
-                        exc_info=True,
+            return result
-                        exception=store_exception,
-                    )
-                else:
-                    self._fail(
-                        ConsumerStatusShortMessage.FAILED,
-                        f"Error occurred while saving {self.filename}.",
-                    )
 
     def _parse_title_placeholders(self, title: str) -> str:
         local_added = timezone.localtime(timezone.now())

src/documents/tests/test_consumer.py

@@ -636,9 +636,16 @@ class TestConsumer(
     @mock.patch("documents.consumer.ConsumerPlugin._store")
     @mock.patch("documents.consumer.document_consumption_finished.send")
     @mock.patch("documents.consumer.generate_unique_filename")
-    def testSaveFailsStillCaught(self, m_filename, m_signal, m_store):
+    def test_post_consume_fails_silently(self, m_filename, m_signal, m_store):
+        """
+        If _store() returns None but no exception is raised, _fail should still be called.
+        """
         filename = self.get_test_file()
+
+        # Make _store() return None
         m_store.return_value = None
+
+        # Cause crash in a predictable, testable place
         m_filename.side_effect = AttributeError("BOOM")
 
         with self.get_consumer(filename) as consumer: