Merge cc999e63373277b17e7f6b10a5f5f59cd189565b into 9a2d7a64acd2e85eb7271a058c21f96f8e4da445

src-ui/messages.xlf

@@ -715,7 +715,7 @@
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/common/input/document-link/document-link.component.html</context>
-          <context context-type="linenumber">58</context>
+          <context context-type="linenumber">59</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/common/permissions-dialog/permissions-dialog.component.html</context>
@@ -5352,18 +5352,18 @@
         <source>Remove link</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/common/input/document-link/document-link.component.html</context>
-          <context context-type="linenumber">43</context>
+          <context context-type="linenumber">44</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/common/input/document-link/document-link.component.html</context>
-          <context context-type="linenumber">50</context>
+          <context context-type="linenumber">51</context>
         </context-group>
       </trans-unit>
       <trans-unit id="1388712764439031120" datatype="html">
         <source>Open link</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/common/input/document-link/document-link.component.html</context>
-          <context context-type="linenumber">46</context>
+          <context context-type="linenumber">47</context>
         </context-group>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/common/input/url/url.component.html</context>
@@ -5374,7 +5374,7 @@
         <source>Not found</source>
         <context-group purpose="location">
           <context context-type="sourcefile">src/app/components/common/input/document-link/document-link.component.html</context>
-          <context context-type="linenumber">51</context>
+          <context context-type="linenumber">52</context>
         </context-group>
       </trans-unit>
       <trans-unit id="5676637575587497817" datatype="html">

src-ui/package.json

@@ -12,17 +12,17 @@
   },
   "private": true,
   "dependencies": {
-    "@angular/cdk": "^19.2.7",
-    "@angular/common": "~19.2.4",
-    "@angular/compiler": "~19.2.4",
-    "@angular/core": "~19.2.4",
-    "@angular/forms": "~19.2.4",
-    "@angular/localize": "~19.2.4",
-    "@angular/platform-browser": "~19.2.4",
-    "@angular/platform-browser-dynamic": "~19.2.4",
-    "@angular/router": "~19.2.4",
+    "@angular/cdk": "^19.2.2",
+    "@angular/common": "~19.2.1",
+    "@angular/compiler": "~19.2.1",
+    "@angular/core": "~19.2.1",
+    "@angular/forms": "~19.2.1",
+    "@angular/localize": "~19.2.1",
+    "@angular/platform-browser": "~19.2.1",
+    "@angular/platform-browser-dynamic": "~19.2.1",
+    "@angular/router": "~19.2.1",
     "@ng-bootstrap/ng-bootstrap": "^18.0.0",
-    "@ng-select/ng-select": "^14.2.6",
+    "@ng-select/ng-select": "^14.2.3",
     "@ngneat/dirty-check-forms": "^3.0.3",
     "@popperjs/core": "^2.11.8",
     "bootstrap": "^5.3.3",
@@ -44,28 +44,28 @@
   "devDependencies": {
     "@angular-builders/custom-webpack": "^19.0.0",
     "@angular-builders/jest": "^19.0.0",
-    "@angular-devkit/build-angular": "^19.2.5",
-    "@angular-devkit/core": "^19.2.5",
-    "@angular-devkit/schematics": "^19.2.5",
-    "@angular-eslint/builder": "19.3.0",
-    "@angular-eslint/eslint-plugin": "19.3.0",
-    "@angular-eslint/eslint-plugin-template": "19.3.0",
-    "@angular-eslint/schematics": "19.3.0",
-    "@angular-eslint/template-parser": "19.3.0",
-    "@angular/cli": "~19.2.5",
-    "@angular/compiler-cli": "~19.2.4",
+    "@angular-devkit/build-angular": "^19.2.1",
+    "@angular-devkit/core": "^19.2.1",
+    "@angular-devkit/schematics": "^19.2.1",
+    "@angular-eslint/builder": "19.2.1",
+    "@angular-eslint/eslint-plugin": "19.2.1",
+    "@angular-eslint/eslint-plugin-template": "19.2.1",
+    "@angular-eslint/schematics": "19.2.1",
+    "@angular-eslint/template-parser": "19.2.1",
+    "@angular/cli": "~19.2.1",
+    "@angular/compiler-cli": "~19.2.1",
     "@codecov/webpack-plugin": "^1.9.0",
-    "@playwright/test": "^1.51.1",
+    "@playwright/test": "^1.50.1",
     "@types/jest": "^29.5.14",
-    "@types/node": "^22.13.17",
-    "@typescript-eslint/eslint-plugin": "^8.29.0",
-    "@typescript-eslint/parser": "^8.29.0",
-    "@typescript-eslint/utils": "^8.29.0",
-    "eslint": "^9.23.0",
+    "@types/node": "^22.13.9",
+    "@typescript-eslint/eslint-plugin": "^8.26.1",
+    "@typescript-eslint/parser": "^8.26.1",
+    "@typescript-eslint/utils": "^8.26.1",
+    "eslint": "^9.22.0",
     "jest": "29.7.0",
     "jest-environment-jsdom": "^29.7.0",
     "jest-junit": "^16.0.0",
-    "jest-preset-angular": "^14.5.4",
+    "jest-preset-angular": "^14.5.3",
     "jest-websocket-mock": "^2.5.0",
     "patch-package": "^8.0.0",
     "prettier-plugin-organize-imports": "^4.1.0",

src-ui/src/app/components/common/input/document-link/document-link.component.html

@@ -30,24 +30,25 @@
     [placeholder]="placeholder"
     [notFoundText]="notFoundText"
     [multiple]="true"
+    bindValue="id"
     [compareWith]="compareDocuments"
     [trackByFn]="trackByFn"
     [minTermLength]="2"
     [loading]="loading"
     [typeahead]="documentsInput$"
     (mousedown)="$event.stopImmediatePropagation()"
-    (change)="onChange(selectedDocumentIDs)">
+    (change)="onChange(selectedDocuments)">
     <ng-template ng-label-tmp let-document="item">
       <div class="d-flex align-items-center">
         @if (!disabled) {
-          <button class="btn p-0 lh-1" (click)="unselect(document)" (mousedown)="$event.stopImmediatePropagation()" type="button" title="Remove link" i18n-title><i-bs name="x"></i-bs></button>
+          <button class="btn p-0 lh-1" (click)="unselect(document)" title="Remove link" i18n-title><i-bs name="x"></i-bs></button>
         }
         @if (document.title) {
           <a routerLink="/documents/{{document.id}}" class="badge bg-light text-primary" (mousedown)="$event.stopImmediatePropagation();" title="Open link" i18n-title>
             <i-bs width="0.9em" height="0.9em" name="file-text"></i-bs>&nbsp;<span>{{document.title}}</span>
           </a>
         } @else {
-          <span class="badge bg-light text-muted" (click)="unselect(document)" (mousedown)="$event.stopImmediatePropagation()" type="button" title="Remove link" i18n-title>
+          <span class="badge bg-light text-muted" (click)="unselect(document)" title="Remove link" i18n-title>
             <i-bs width="0.9em" height="0.9em" name="exclamation-triangle-fill"></i-bs>&nbsp;<span i18n>Not found</span>
           </span>
         }

src-ui/src/app/components/common/input/document-link/document-link.component.spec.ts

@@ -74,11 +74,6 @@ describe('DocumentLinkComponent', () => {
     expect(component.selectedDocuments).toEqual([documents[1], documents[0]])
   })
 
-  it('should retrieve document IDs from selected documents', () => {
-    component.selectedDocuments = documents
-    expect(component.selectedDocumentIDs).toEqual([1, 12, 16, 23])
-  })
-
   it('should search API on select text input', () => {
     const listSpy = jest.spyOn(documentService, 'listFiltered')
     listSpy.mockImplementation(

src-ui/src/app/components/common/input/document-link/document-link.component.ts

@@ -71,10 +71,6 @@ export class DocumentLinkComponent
   @Input()
   placeholder: string = $localize`Search for documents`
 
-  get selectedDocumentIDs(): number[] {
-    return this.selectedDocuments.map((d) => d.id)
-  }
-
   constructor(private documentsService: DocumentService) {
     super()
   }

src-ui/src/app/components/common/input/tags/tags.component.html

@@ -17,7 +17,7 @@
           (change)="onChange(value)">
 
           <ng-template ng-label-tmp let-item="item">
-            <button class="tag-wrap btn p-0 d-flex align-items-center" (click)="removeTag(item.id)" (mousedown)="$event.stopImmediatePropagation()" type="button" title="Remove tag" i18n-title>
+            <button class="tag-wrap btn p-0 d-flex align-items-center" (click)="removeTag($event, item.id)" title="Remove tag" i18n-title>
               <i-bs name="x" style="margin-inline-end: 1px;"></i-bs>
               @if (item.id && tags) {
                 <pngx-tag style="background-color: none;" [tag]="getTag(item.id)"></pngx-tag>

src-ui/src/app/components/common/input/tags/tags.component.spec.ts

@@ -154,11 +154,11 @@ describe('TagsComponent', () => {
   it('support remove tags', () => {
     component.tags = tags
     component.value = [1, 2]
-    component.removeTag(2)
+    component.removeTag(new PointerEvent('point'), 2)
     expect(component.value).toEqual([1])
 
     component.disabled = true
-    component.removeTag(1)
+    component.removeTag(new PointerEvent('point'), 1)
     expect(component.value).toEqual([1])
   })
 

src-ui/src/app/components/common/input/tags/tags.component.ts

@@ -118,10 +118,13 @@ export class TagsComponent implements OnInit, ControlValueAccessor {
     }
   }
 
-  removeTag(tagID: number) {
+  removeTag(event: PointerEvent, id: number) {
     if (this.disabled) return
 
-    let index = this.value.indexOf(tagID)
+    // prevent opening dropdown
+    event.stopImmediatePropagation()
+
+    let index = this.value.indexOf(id)
     if (index > -1) {
       let oldValue = this.value
       oldValue.splice(index, 1)