mirror of
https://github.com/paperless-ngx/paperless-ngx.git
synced 2025-04-02 13:45:10 -05:00
Avoid TOCTOU error by rather catching an exception than checking
beforehand
This commit is contained in:
parent
6a671ebd22
commit
05da4a559f
@ -450,9 +450,9 @@ def delete_files(sender, instance, **kwargs):
|
||||
# Remove the document
|
||||
old_file = instance.filename_to_path(instance.filename)
|
||||
|
||||
if os.path.isfile(old_file):
|
||||
try:
|
||||
os.remove(old_file)
|
||||
else:
|
||||
except FileNotFoundError:
|
||||
logger = logging.getLogger(__name__)
|
||||
logger.warning("Deleted document " + str(instance.id) + " but file " +
|
||||
old_file + " was no longer present")
|
||||
|
Loading…
x
Reference in New Issue
Block a user