paradizelost/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2025-04-02 13:45:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Reduce calls to isDirty for filterable dropdowns

Browse Source 
And make disabled more visually obvious
This commit is contained in:
Michael Shamoon 2022-02-20 01:08:42 -08:00
parent 17ddf18a67
commit 7049d04d71
3 changed files with 11 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.html
View File

@ -35,8 +35,8 @@
<app-toggleable-dropdown-button *ngIf="allowSelectNone || item.id" [item]="item" [state]="selectionModel.get(item.id)" (toggle)="selectionModel.toggle(item.id)" (exclude)="excludeClicked(item.id)"></app-toggleable-dropdown-button>
</ng-container>
</div>
<button *ngIf="editing" class="list-group-item list-group-item-action bg-light" (click)="applyClicked()" [disabled]="!selectionModel.isDirty()">
<small class="ms-2" [ngClass]="{'fw-bold': selectionModel.isDirty()}" i18n>Apply</small>
<button *ngIf="editing" class="list-group-item list-group-item-action bg-light" (click)="applyClicked()" [disabled]="!modelIsDirty">
<small class="ms-2" [ngClass]="{'fw-bold': modelIsDirty}" i18n>Apply</small>
<svg width="1.5em" height="1em" viewBox="0 0 16 16" fill="currentColor">
<use xlink:href="assets/bootstrap-icons.svg#arrow-right" />
</svg>

4
src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.scss
View File

@ -13,6 +13,10 @@
max-height: 400px;
overflow-y: scroll;
}
button:disabled {
opacity: 0.2;
}
}
.btn-group-xs {

5
src-ui/src/app/components/common/filterable-dropdown/filterable-dropdown.component.ts
View File

@ -275,8 +275,13 @@ export class FilterableDropdownComponent {
return this.selectionModel.selectionSize() > 1 && this.selectionModel.getExcludedItems().length == 0
}
modelIsDirty: boolean = false
constructor(private filterPipe: FilterPipe) {
this.selectionModel = new FilterableDropdownSelectionModel()
this.selectionModelChange.subscribe(updatedModel => {
this.modelIsDirty = updatedModel.isDirty()
})
}
applyClicked() {