paradizelost/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2026-02-22 00:49:35 -06:00
Code Issues Packages Projects Releases Wiki Activity

Frontend handle this change

Browse Source
This commit is contained in:
shamoon
2026-02-20 14:03:38 -08:00
parent 34bdf41931
commit 7bcfcf1e49
5 changed files with 15 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src-ui/src/app/components/document-list/document-list.component.spec.ts
View File

@@ -579,8 +579,6 @@ describe('DocumentListComponent', () => {
expect(savedViewServiceCreate).toHaveBeenCalledWith(
expect.objectContaining({
name: 'Foo Bar',
show_on_dashboard: false,
show_in_sidebar: false,
owner: permissions.owner,
set_permissions: permissions.set_permissions,
})

3
src-ui/src/app/components/document-list/document-list.component.ts
View File

@@ -446,9 +446,6 @@ export class DocumentListComponent
modal.componentInstance.buttonsEnabled = false
let savedView: SavedView = {
name: formValue.name,
// Visibility is in per-user UISettings.
show_on_dashboard: false,
show_in_sidebar: false,
filter_rules: this.list.filterRules,
sort_reverse: this.list.sortReverse,
sort_field: this.list.sortField,

4
src-ui/src/app/data/ui-settings.ts
View File

@@ -255,12 +255,12 @@ export const SETTINGS: UiSetting[] = [
{
key: SETTINGS_KEYS.DASHBOARD_VIEWS_VISIBLE_IDS,
type: 'array',
default: null,
default: [],
},
{
key: SETTINGS_KEYS.SIDEBAR_VIEWS_VISIBLE_IDS,
type: 'array',
default: null,
default: [],
},
{
key: SETTINGS_KEYS.DASHBOARD_VIEWS_SORT_ORDER,

9
src-ui/src/app/services/rest/saved-view.service.spec.ts
View File

@@ -57,6 +57,11 @@ describe(`Additional service tests for SavedViewService`, () => {
let settingsService
it('should retrieve saved views and sort them', () => {
jest.spyOn(settingsService, 'get').mockImplementation((key) => {
if (key === SETTINGS_KEYS.DASHBOARD_VIEWS_VISIBLE_IDS) return [1, 2, 3]
if (key === SETTINGS_KEYS.SIDEBAR_VIEWS_VISIBLE_IDS) return [1, 2, 3]
return []
})
service.reload()
const req = httpTestingController.expectOne(
`${environment.apiBaseUrl}${endpoint}/?page=1&page_size=100000`
@@ -93,7 +98,9 @@ describe(`Additional service tests for SavedViewService`, () => {
it('should sort dashboard views', () => {
service['savedViews'] = saved_views
jest.spyOn(settingsService, 'get').mockImplementation((key) => {
if (key === SETTINGS_KEYS.DASHBOARD_VIEWS_VISIBLE_IDS) return [1, 2, 3]
if (key === SETTINGS_KEYS.DASHBOARD_VIEWS_SORT_ORDER) return [3, 1, 2]
return []
})
expect(service.dashboardViews).toEqual([
saved_views[2],
@@ -114,7 +121,9 @@ describe(`Additional service tests for SavedViewService`, () => {
it('should sort sidebar views', () => {
service['savedViews'] = saved_views
jest.spyOn(settingsService, 'get').mockImplementation((key) => {
if (key === SETTINGS_KEYS.SIDEBAR_VIEWS_VISIBLE_IDS) return [1, 2, 3]
if (key === SETTINGS_KEYS.SIDEBAR_VIEWS_SORT_ORDER) return [3, 1, 2]
return []
})
expect(service.sidebarViews).toEqual([
saved_views[2],

8
src-ui/src/app/services/rest/saved-view.service.ts
View File

@@ -67,9 +67,9 @@ export class SavedViewService extends AbstractPaperlessService<SavedView> {
return this.savedViews
}
private getVisibleViewIds(setting: string): number[] | null {
private getVisibleViewIds(setting: string): number[] {
const configured = this.settingsService.get(setting)
return Array.isArray(configured) ? configured : null
return Array.isArray(configured) ? configured : []
}
private withUserVisibility(view: SavedView): SavedView {
@@ -84,14 +84,14 @@ export class SavedViewService extends AbstractPaperlessService<SavedView> {
const visibleIds = this.getVisibleViewIds(
SETTINGS_KEYS.DASHBOARD_VIEWS_VISIBLE_IDS
)
return visibleIds ? visibleIds.includes(view.id) : !!view.show_on_dashboard
return visibleIds.includes(view.id)
}
private isSidebarVisible(view: SavedView): boolean {
const visibleIds = this.getVisibleViewIds(
SETTINGS_KEYS.SIDEBAR_VIEWS_VISIBLE_IDS
)
return visibleIds ? visibleIds.includes(view.id) : !!view.show_in_sidebar
return visibleIds.includes(view.id)
}
get sidebarViews(): SavedView[] {