paradizelost/paperless-ngx
1
0
Fork 0
mirror of https://github.com/paperless-ngx/paperless-ngx.git synced 2025-04-02 13:45:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fixes the interaction when both splitting and ASN are enabled (#5779)

Browse Source
This commit is contained in:
Trenton H 2024-02-15 09:33:26 -08:00 committed by GitHub
parent f6ddcfa839
commit 8d664fad56
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/documents/barcodes.py
View File

@ -100,11 +100,9 @@ class BarcodePlugin(ConsumeTaskPlugin):
logger.info(f"Found tags in barcode: {tags}")
# Lastly attempt to split documents
if settings.CONSUMER_ENABLE_BARCODES:
separator_pages = self.get_separation_pages()
if not separator_pages:
return "No pages to split on!"
if settings.CONSUMER_ENABLE_BARCODES and (
separator_pages := self.get_separation_pages()
):
# We have pages to split against

6
src/documents/tests/test_barcodes.py
View File

@ -15,6 +15,7 @@ from documents.data_models import ConsumableDocument
from documents.data_models import DocumentMetadataOverrides
from documents.data_models import DocumentSource
from documents.models import Tag
from documents.plugins.base import StopConsumeTaskError
from documents.tests.utils import DirectoriesMixin
from documents.tests.utils import DocumentConsumeDelayMixin
from documents.tests.utils import DummyProgressManager
@ -415,7 +416,10 @@ class TestBarcode(
test_file = self.SAMPLE_DIR / "simple.pdf"
with self.get_reader(test_file) as reader:
self.assertEqual("No pages to split on!", reader.run())
try:
reader.run()
except StopConsumeTaskError:
self.fail("Barcode reader split pages unexpectedly")
@override_settings(
CONSUMER_ENABLE_BARCODES=True,