Sonar fixes

This commit is contained in:
shamoon
2025-12-30 13:56:54 -08:00
parent b55256770d
commit 9c8c1b8fa8
4 changed files with 11 additions and 10 deletions

View File

@@ -42,6 +42,7 @@
role="switch" role="switch"
id="shareArchiveSwitch" id="shareArchiveSwitch"
formControlName="shareArchiveVersion" formControlName="shareArchiveVersion"
aria-checked="{{ shareArchiveVersion }}"
/> />
<label class="form-check-label" for="shareArchiveSwitch" i18n>Share archive version (if available)</label> <label class="form-check-label" for="shareArchiveSwitch" i18n>Share archive version (if available)</label>
</div> </div>

View File

@@ -34,16 +34,16 @@ import { ConfirmDialogComponent } from '../confirm-dialog/confirm-dialog.compone
providers: [], providers: [],
}) })
export class ShareLinkBundleDialogComponent extends ConfirmDialogComponent { export class ShareLinkBundleDialogComponent extends ConfirmDialogComponent {
private formBuilder = inject(FormBuilder) private readonly formBuilder = inject(FormBuilder)
private clipboard = inject(Clipboard) private readonly clipboard = inject(Clipboard)
private toastService = inject(ToastService) private readonly toastService = inject(ToastService)
private _documents: Document[] = [] private _documents: Document[] = []
selectionCount = 0 selectionCount = 0
documentPreview: Document[] = [] documentPreview: Document[] = []
form: FormGroup = this.formBuilder.group({ form: FormGroup = this.formBuilder.group({
shareArchiveVersion: [true], shareArchiveVersion: true,
expirationDays: [7], expirationDays: [7],
}) })
payload: ShareLinkBundleCreatePayload | null = null payload: ShareLinkBundleCreatePayload | null = null

View File

@@ -32,10 +32,10 @@ export class ShareLinkBundleManageDialogComponent
extends LoadingComponentWithPermissions extends LoadingComponentWithPermissions
implements OnInit, OnDestroy implements OnInit, OnDestroy
{ {
private activeModal = inject(NgbActiveModal) private readonly activeModal = inject(NgbActiveModal)
private shareLinkBundleService = inject(ShareLinkBundleService) private readonly shareLinkBundleService = inject(ShareLinkBundleService)
private toastService = inject(ToastService) private readonly toastService = inject(ToastService)
private clipboard = inject(Clipboard) private readonly clipboard = inject(Clipboard)
title = $localize`Share link bundles` title = $localize`Share link bundles`

View File

@@ -90,7 +90,7 @@ export class BulkEditorComponent
private customFieldService = inject(CustomFieldsService) private customFieldService = inject(CustomFieldsService)
private permissionService = inject(PermissionsService) private permissionService = inject(PermissionsService)
private savedViewService = inject(SavedViewService) private savedViewService = inject(SavedViewService)
private shareLinkBundleService = inject(ShareLinkBundleService) private readonly shareLinkBundleService = inject(ShareLinkBundleService)
tagSelectionModel = new FilterableDropdownSelectionModel(true) tagSelectionModel = new FilterableDropdownSelectionModel(true)
correspondentSelectionModel = new FilterableDropdownSelectionModel() correspondentSelectionModel = new FilterableDropdownSelectionModel()
@@ -962,7 +962,7 @@ export class BulkEditorComponent
} }
manageShareLinkBundles() { manageShareLinkBundles() {
const modal = this.modalService.open(ShareLinkBundleManageDialogComponent, { this.modalService.open(ShareLinkBundleManageDialogComponent, {
backdrop: 'static', backdrop: 'static',
size: 'lg', size: 'lg',
}) })