Make codeQL happy

This commit is contained in:
shamoon
2025-09-11 21:39:33 -07:00
parent ec9c1d2fd6
commit ac1b0efc19
2 changed files with 5 additions and 3 deletions

View File

@@ -591,7 +591,8 @@ class TagSerializer(MatchingModelSerializer, OwnedObjectSerializer):
self.instance.parent = parent self.instance.parent = parent
self.instance.clean() self.instance.clean()
except ValidationError as e: except ValidationError as e:
raise serializers.ValidationError({"parent": list(e)}) logger.debug("Tag parent validation failed: %s", e)
raise serializers.ValidationError({"parent": _("Invalid parent tag.")})
finally: finally:
self.instance.parent = original_parent self.instance.parent = original_parent
else: else:
@@ -600,7 +601,8 @@ class TagSerializer(MatchingModelSerializer, OwnedObjectSerializer):
try: try:
temp.clean() temp.clean()
except ValidationError as e: except ValidationError as e:
raise serializers.ValidationError({"parent": list(e)}) logger.debug("Tag parent validation failed: %s", e)
raise serializers.ValidationError({"parent": _("Invalid parent tag.")})
return super().validate(attrs) return super().validate(attrs)

View File

@@ -161,7 +161,7 @@ class TestTagHierarchy(APITestCase):
) )
assert resp_fail.status_code == 400 assert resp_fail.status_code == 400
assert "parent" in resp_fail.data assert "parent" in resp_fail.data
assert any("Maximum" in str(msg) for msg in resp_fail.data["parent"]) assert "Invalid" in str(resp_fail.data["parent"])
def test_max_depth_on_move_subtree(self): def test_max_depth_on_move_subtree(self):
a = Tag.objects.create(name="A2") a = Tag.objects.create(name="A2")