Chore(deps): Bump gotenberg-client in the document-processing group

Bumps the document-processing group with 1 update: [gotenberg-client](https://github.com/stumpylog/gotenberg-client). Updates `gotenberg-client` from 0.12.0 to 0.13.0 - [Release notes](https://github.com/stumpylog/gotenberg-client/releases) - [Changelog](https://github.com/stumpylog/gotenberg-client/blob/main/CHANGELOG.md) - [Commits](https://github.com/stumpylog/gotenberg-client/compare/0.12.0...0.13.0) --- updated-dependencies: - dependency-name: gotenberg-client dependency-version: 0.13.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: document-processing ... Signed-off-by: dependabot[bot] <support@github.com>
2025-12-10 01:01:17 -06:00 · 2025-12-08 20:17:34 +00:00
4 changed files with 11 additions and 122 deletions
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -45,7 +45,7 @@ dependencies = [
  "drf-writable-nested~=0.7.1",
  "filelock~=3.20.0",
  "flower~=2.0.1",
-  "gotenberg-client~=0.12.0",
+  "gotenberg-client~=0.13.1",
  "httpx-oauth~=0.16",
  "imap-tools~=1.11.0",
  "inotifyrecursive~=0.3",
--- a/src/documents/signals/handlers.py
+++ b/src/documents/signals/handlers.py
@@ -33,7 +33,6 @@ from documents import matching
 from documents.caching import clear_document_caches
 from documents.file_handling import create_source_path_directory
 from documents.file_handling import delete_empty_directories
-from documents.file_handling import generate_filename
 from documents.file_handling import generate_unique_filename
 from documents.mail import EmailAttachment
 from documents.mail import send_email
@@ -53,7 +52,6 @@ from documents.models import WorkflowRun
 from documents.models import WorkflowTrigger
 from documents.permissions import get_objects_for_user_owner_aware
 from documents.permissions import set_permissions_for_object
-from documents.templating.utils import convert_format_str_to_template_format
 from documents.templating.workflows import parse_w_workflow_placeholders

 if TYPE_CHECKING:
@@ -394,19 +392,6 @@ class CannotMoveFilesException(Exception):
    pass


-def _filename_template_uses_custom_fields(doc: Document) -> bool:
-    template = None
-    if doc.storage_path is not None:
-        template = doc.storage_path.path
-    elif settings.FILENAME_FORMAT is not None:
-        template = convert_format_str_to_template_format(settings.FILENAME_FORMAT)
-
-    if not template:
-        return False
-
-    return "custom_fields" in template
-
-
 # should be disabled in /src/documents/management/commands/document_importer.py handle
@receiver(models.signals.post_save, sender=CustomFieldInstance, weak=False)
@receiver(models.signals.m2m_changed, sender=Document.tags.through, weak=False)
@@ -417,8 +402,6 @@ def update_filename_and_move_files(
    **kwargs,
 ):
    if isinstance(instance, CustomFieldInstance):
-        if not _filename_template_uses_custom_fields(instance.document):
-            return
        instance = instance.document

    def validate_move(instance, old_path: Path, new_path: Path):
@@ -456,47 +439,21 @@ def update_filename_and_move_files(
            old_filename = instance.filename
            old_source_path = instance.source_path

-            candidate_filename = generate_filename(instance)
-            candidate_source_path = (
-                settings.ORIGINALS_DIR / candidate_filename
-            ).resolve()
-            if candidate_filename == Path(old_filename):
-                new_filename = Path(old_filename)
-            elif (
-                candidate_source_path.exists()
-                and candidate_source_path != old_source_path
-            ):
-                # Only fall back to unique search when there is an actual conflict
-                new_filename = generate_unique_filename(instance)
-            else:
-                new_filename = candidate_filename
-
            # Need to convert to string to be able to save it to the db
-            instance.filename = str(new_filename)
+            instance.filename = str(generate_unique_filename(instance))
            move_original = old_filename != instance.filename

            old_archive_filename = instance.archive_filename
            old_archive_path = instance.archive_path

            if instance.has_archive_version:
-                archive_candidate = generate_filename(instance, archive_filename=True)
-                archive_candidate_path = (
-                    settings.ARCHIVE_DIR / archive_candidate
-                ).resolve()
-                if archive_candidate == Path(old_archive_filename):
-                    new_archive_filename = Path(old_archive_filename)
-                elif (
-                    archive_candidate_path.exists()
-                    and archive_candidate_path != old_archive_path
-                ):
-                    new_archive_filename = generate_unique_filename(
+                # Need to convert to string to be able to save it to the db
+                instance.archive_filename = str(
+                    generate_unique_filename(
                        instance,
                        archive_filename=True,
-                    )
-                else:
-                    new_archive_filename = archive_candidate
-
-                instance.archive_filename = str(new_archive_filename)
+                    ),
+                )

                move_archive = old_archive_filename != instance.archive_filename
            else:
--- a/src/documents/tests/test_file_handling.py
+++ b/src/documents/tests/test_file_handling.py
@@ -16,7 +16,6 @@ from django.utils import timezone
 from documents.file_handling import create_source_path_directory
 from documents.file_handling import delete_empty_directories
 from documents.file_handling import generate_filename
-from documents.file_handling import generate_unique_filename
 from documents.models import Correspondent
 from documents.models import CustomField
 from documents.models import CustomFieldInstance
@@ -1633,73 +1632,6 @@ class TestFilenameGeneration(DirectoriesMixin, TestCase):
            )


-class TestCustomFieldFilenameUpdates(
-    DirectoriesMixin,
-    FileSystemAssertsMixin,
-    TestCase,
-):
-    def setUp(self):
-        self.cf = CustomField.objects.create(
-            name="flavor",
-            data_type=CustomField.FieldDataType.STRING,
-        )
-        self.doc = Document.objects.create(
-            title="document",
-            mime_type="application/pdf",
-            checksum="abc123",
-        )
-        self.cfi = CustomFieldInstance.objects.create(
-            field=self.cf,
-            document=self.doc,
-            value_text="initial",
-        )
-        return super().setUp()
-
-    @override_settings(FILENAME_FORMAT=None)
-    def test_custom_field_not_in_template_skips_filename_work(self):
-        storage_path = StoragePath.objects.create(path="{{created}}/{{ title }}")
-        self.doc.storage_path = storage_path
-        self.doc.save()
-        initial_filename = generate_filename(self.doc)
-        Document.objects.filter(pk=self.doc.pk).update(filename=str(initial_filename))
-        self.doc.refresh_from_db()
-        Path(self.doc.source_path).parent.mkdir(parents=True, exist_ok=True)
-        Path(self.doc.source_path).touch()
-
-        with mock.patch("documents.signals.handlers.generate_unique_filename") as m:
-            m.side_effect = generate_unique_filename
-            self.cfi.value_text = "updated"
-            self.cfi.save()
-
-        self.doc.refresh_from_db()
-        self.assertEqual(Path(self.doc.filename), initial_filename)
-        self.assertEqual(m.call_count, 0)
-
-    @override_settings(FILENAME_FORMAT=None)
-    def test_custom_field_in_template_triggers_filename_update(self):
-        storage_path = StoragePath.objects.create(
-            path="{{ custom_fields|get_cf_value('flavor') }}/{{ title }}",
-        )
-        self.doc.storage_path = storage_path
-        self.doc.save()
-        initial_filename = generate_filename(self.doc)
-        Document.objects.filter(pk=self.doc.pk).update(filename=str(initial_filename))
-        self.doc.refresh_from_db()
-        Path(self.doc.source_path).parent.mkdir(parents=True, exist_ok=True)
-        Path(self.doc.source_path).touch()
-
-        with mock.patch("documents.signals.handlers.generate_unique_filename") as m:
-            m.side_effect = generate_unique_filename
-            self.cfi.value_text = "updated"
-            self.cfi.save()
-
-        self.doc.refresh_from_db()
-        expected_filename = Path("updated/document.pdf")
-        self.assertEqual(Path(self.doc.filename), expected_filename)
-        self.assertTrue(Path(self.doc.source_path).is_file())
-        self.assertLessEqual(m.call_count, 1)
-
-
 class TestPathDateLocalization:
    """
    Groups all tests related to the `localize_date` function.
--- a/uv.lock
+++ b/uv.lock
@@ -1073,15 +1073,15 @@ wheels = [

 [[package]]
 name = "gotenberg-client"
-version = "0.12.0"
+version = "0.13.1"
 source = { registry = "https://pypi.org/simple" }
 dependencies = [
    { name = "httpx", extra = ["http2"], marker = "sys_platform == 'darwin' or sys_platform == 'linux'" },
    { name = "typing-extensions", marker = "(python_full_version < '3.11' and sys_platform == 'darwin') or (python_full_version < '3.11' and sys_platform == 'linux')" },
 ]
-sdist = { url = "https://files.pythonhosted.org/packages/61/6d/07ea213c146bbe91dffebff2d8f4dc61e7076d3dd34d4fd1467f9163e752/gotenberg_client-0.12.0.tar.gz", hash = "sha256:1ab50878024469fc003c414ee9810ceeb00d4d7d7c36bd2fb75318fbff139e9b", size = 1210884, upload-time = "2025-10-15T15:32:37.669Z" }
+sdist = { url = "https://files.pythonhosted.org/packages/e4/6c/aaadd6657ca42fbd148b1c00604b98c1ead5a22552f4e5365ce5f0632430/gotenberg_client-0.13.1.tar.gz", hash = "sha256:cdd6bbb535cd739b87446cd1b4f6347ed7f9af6a0d4b19baf7c064b75528ee54", size = 1211143, upload-time = "2025-12-04T20:45:24.151Z" }
 wheels = [
-    { url = "https://files.pythonhosted.org/packages/12/39/fcb24ff053b1be7e5124f56c3d358706a23a328f685c6db33bc9dbc5472d/gotenberg_client-0.12.0-py3-none-any.whl", hash = "sha256:a540b35ac518e902c2860a88fbe448c15fe5a56fe8ec8604e6a2c8c2228fd0cb", size = 51051, upload-time = "2025-10-15T15:32:36.32Z" },
+    { url = "https://files.pythonhosted.org/packages/79/f6/7a6e6785295332d2538f729ae19516cef712273a5ab8b90d015f08e37a45/gotenberg_client-0.13.1-py3-none-any.whl", hash = "sha256:613f7083a5e8a81699dd8d715c97e5806a424ac48920aad25d7c11b600cdfaf3", size = 51058, upload-time = "2025-12-04T20:45:22.603Z" },
 ]

 [[package]]
@@ -2281,7 +2281,7 @@ requires-dist = [
    { name = "drf-writable-nested", specifier = "~=0.7.1" },
    { name = "filelock", specifier = "~=3.20.0" },
    { name = "flower", specifier = "~=2.0.1" },
-    { name = "gotenberg-client", specifier = "~=0.12.0" },
+    { name = "gotenberg-client", specifier = "~=0.13.1" },
    { name = "granian", extras = ["uvloop"], marker = "extra == 'webserver'", specifier = "~=2.5.1" },
    { name = "httpx-oauth", specifier = "~=0.16" },
    { name = "imap-tools", specifier = "~=1.11.0" },